You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I wonder whether it would be feasible to update the codebase a bit with regards to modern C++ constructs.
In particular, esp-nimble-cpp relies a lot on pointers (e.g., for callbacks). Devices such as std::unique_ptr and std::shared_ptr could improve this a lot.
But also trivial things like using auto and for (auto& item: collection) could help to make the codebase more simple to read, more friendly towards contributions, and better maintainable.
What's your take on that?
The text was updated successfully, but these errors were encountered:
I wonder whether it would be feasible to update the codebase a bit with regards to modern C++ constructs.
In particular, esp-nimble-cpp relies a lot on pointers (e.g., for callbacks). Devices such as
std::unique_ptr
andstd::shared_ptr
could improve this a lot.But also trivial things like using
auto
andfor (auto& item: collection)
could help to make the codebase more simple to read, more friendly towards contributions, and better maintainable.What's your take on that?
The text was updated successfully, but these errors were encountered: