Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernizing the codebase #154

Open
mickeyl opened this issue Apr 8, 2024 · 1 comment
Open

Modernizing the codebase #154

mickeyl opened this issue Apr 8, 2024 · 1 comment

Comments

@mickeyl
Copy link

mickeyl commented Apr 8, 2024

I wonder whether it would be feasible to update the codebase a bit with regards to modern C++ constructs.

In particular, esp-nimble-cpp relies a lot on pointers (e.g., for callbacks). Devices such as std::unique_ptr and std::shared_ptr could improve this a lot.

But also trivial things like using auto and for (auto& item: collection) could help to make the codebase more simple to read, more friendly towards contributions, and better maintainable.

What's your take on that?

@h2zero
Copy link
Owner

h2zero commented Apr 20, 2024

Yes I've wanted to do some cleanup as the code is based on a pretty old library now. I just haven't had time or any real need for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants