Skip to content
This repository has been archived by the owner on Nov 23, 2018. It is now read-only.

CSS filename replacement in HTML is placing quotes in incorrect places when HTML is actually a server side template #153

Open
kierans opened this issue Mar 15, 2013 · 0 comments

Comments

@kierans
Copy link

kierans commented Mar 15, 2013

For my project the CSS is concatenated/minified by h5bp however the HTML pages are actually JSP tag templates. The current replacement regexp is assuming where the quotes should go and this is causing problems when using JSP snippets eg:

<link rel="stylesheet" href="<%= application.getContextPath() + "/css/main.css" %>">

produces

<link rel="stylesheet" href='<%= application.getContextPath() + "/css/3f2f17c.css' %>">

which causes JSP errors, as the single quotes are added by the Ant regexp replace.

The regexp IMO should actually capture everything (including quotes) around the filename ie: main.css and just replace the filename.

I'll be submitting a pull request with a fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant