Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong editorDependencies (H5P.CoursePresentation instead of H5PEditor.CoursePresentation) #311

Open
sarjona opened this issue Sep 27, 2024 · 3 comments

Comments

@sarjona
Copy link

sarjona commented Sep 27, 2024

One of the editorDependencies in the library.json doesn't look good in the latest version:

"editorDependencies": [
    {
      "machineName": "H5P.CoursePresentation",
      "majorVersion": 1,
      "minorVersion": 26
    },

Shouldn't machineName be H5PEditor.CoursePresentation ? The Course presentation content type is not installed/updated with the latest coreApi H5P libraries (1.27) and this seems the root cause.

@otacke
Copy link
Contributor

otacke commented Sep 30, 2024

@sarjona Github is hardly ever looked at, unfortunately. While one could link issues and pull requests to JIRA automatically, that's not done. Reporting via https://h5ptechnology.atlassian.net/jira/software/c/projects/HFP/issues/ might be more effective.

@sarjona
Copy link
Author

sarjona commented Oct 1, 2024

Hi @otacke!
Thanks a lot for the tip! I've just created https://h5ptechnology.atlassian.net/browse/HFP-4126 :-)

@otacke
Copy link
Contributor

otacke commented Oct 1, 2024

@sarjona Hanna will notice it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants