-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes for release pipeline (aarch64) #9481
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Phani Sajja <[email protected]>
👷 Deploy Preview for chef-habitat processing.
|
You actually want the release channel to fall back t oLTS-2024. The "primary" HAB_BLDR_CHANNEL should be a dynamically created channel based on the I'm looking at https://buildkite.com/chef/habitat-sh-habitat-main-release-habitat/builds/2002 where the release pipeline is failing. For some reason hab-plan-build is not honoring |
For aarch64, we have core packages in the LTS-2024 channel, and the hab* packages built against them are placed in the stable channel. habitat/components/plan-build/bin/hab-plan-build.sh Lines 691 to 698 in 9ef672b
It appears that with the introduction of HAB_REFRESH_CHANNEL, the HAB_BLDR_CHANNEL is no longer honored for core packages. For |
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
.expeditor/verify.pipeline.yml
Outdated
@@ -853,7 +853,7 @@ steps: | |||
HAB_LICENSE: "accept-no-persist" | |||
HAB_BLDR_CHANNEL: "LTS-2024" | |||
HAB_REFRESH_CHANNEL: "LTS-2024" | |||
HAB_FALLBACK_CHANNEL: "lts24-aarch64-linux" | |||
HAB_FALLBACK_CHANNEL: "stable" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove all of these HAB_FALLBACK_CHANNEL
exports in the file. stable
is the default. However, if you did want to override stable
then you would need to use HAB_STUDIO_SECRET_HAB_FALLBACK_CHANNEL
. HAB_FALLBACK_CHANNEL
will not get passed into the studio.
@@ -19,12 +19,9 @@ HAB_CACHE_KEY_PATH="$JOB_TEMP_ROOT/keys" | |||
|
|||
export HAB_STUDIO_SECRET_HAB_FALLBACK_CHANNEL | |||
HAB_STUDIO_SECRET_HAB_FALLBACK_CHANNEL="$HAB_FALLBACK_CHANNEL" | |||
export HAB_PREFER_LOCAL_CHEF_DEPS="true" | |||
export HAB_PREFER_LOCAL_CHEF_DEPS="false" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you want to remove, this is the default
I ran a test release build from this branch and the built components used in the front of the pipeline are not getting consumed by their dependent components. This can be seen in https://buildkite.com/chef/habitat-sh-habitat-main-release-habitat/builds/2009#019397ab-5b97-486b-8433-7dc6b7bfb6c1/429-693. Here the core/hab built at the beginning of the pipeline is I think what you need to do to fix this is set |
Signed-off-by: Phani Sajja <[email protected]>
If we set HAB_STUDIO_SECRET_HAB_REFRESH_CHANNEL to the release channel with a fallback to LTS-2024, it will only fetch the latest hab binary from the release channel. This raises the question of where hab-studio is being sourced from, as it is essential for building any component. |
You want the core/hab that builds with the down stream components to be pulled from the release channel. Otherwise, plan-build and the exporters won't include the correct core/hab. The core/hab and studio used to actually do the build will also come from the release channel if they have both been build, but I'm pretty sure that in the earlier stages of the pipeline, it just uses the latest stable hab. At any rate, in the end, we have to make sure that the release pipeline produces artifacts that all reflect the components that were built off of main. Currently it doesn't look like that is happening here. |
Signed-off-by: Phani Sajja <[email protected]>
Updated to point the hab refresh channel to the release channel and set the fallback to LTS-2024 for aarch64. |
components/studio/bin/hab-studio.sh
Outdated
i=1 | ||
while [ "$i" -le "$MAX_RETRIES" ] | ||
do | ||
sleep $((RETRY_DELAY * i)) # Delay increases with each retry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm seeing this error in the verify pipeline (https://buildkite.com/chef/habitat-sh-habitat-main-verify/builds/13587#0193abd2-ff85-4a2c-aa7b-eade362a53ca/194-772): /hab/pkgs/core/hab-studio/1.6.1218/20241127103841/bin/hab-studio: line 1075: sleep: No such file or directory
. I know sleep lives in coreutils and that probably is not binlinked in the studio.
Signed-off-by: Phani Sajja <[email protected]>
@@ -101,6 +101,9 @@ finish_setup() { | |||
_hab pkg binlink core/bash bash | |||
_hab pkg binlink core/bash sh | |||
|
|||
# binlink sleep command | |||
_hab pkg binlink "$coreutils_path/bin/sleep" sleep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be _hab pkg binlink core/coreutils sleep
Signed-off-by: Phani Sajja <[email protected]>
@sajjaphani still seeing issues with |
This is happening because the older studio does not have sleep symlinked. I’ve rebuilt and uploaded the package, and it is now passing the pipeline. |
In the release pipeline, I see it built the studio fine and then when it builds the launcher, it uses that studio and I see it binlinking |
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Currently, the release pipeline is failing because it is falling back to the LTS-2024 channel, where none of the
hab*
packages exist. To unblock the release pipeline, the fallback channel has been updated tostable
.Note: The hab, hab-studio, hab-backline, and hab-plan-build packages with version
1.6.11781.6.1218 have been promoted to the stable channel.