Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug where refresh neccessary after sign in. #143

Closed
wants to merge 3 commits into from
Closed

Fixed bug where refresh neccessary after sign in. #143

wants to merge 3 commits into from

Conversation

syanase-calpoly
Copy link
Collaborator

Developer: Shuya Yanase

Closes #123

Pull Request Summary

  • I fixed a bug where after sign in, it would require a refresh to see that you actually signed in on the navbar

Modifications

  • I modified the sign in page so that it would require refresh when sent to home page since navbar is server component so cant be modified without a refresh

Testing Considerations

Pull Request Checklist

  • [x ] Code is neat, readable, and works
  • [x ] Comments are appropriate
  • [x ] The commit messages follows our guidelines
  • [x ] The developer name is specified
  • [x ] The summary is completed
  • [x ] Assign reviewers

Screenshots/Screencast

Untitled_.May.12.2024.11_02.PM.webm

@syanase-calpoly syanase-calpoly linked an issue May 13, 2024 that may be closed by this pull request
Bug Bundle #1 #123
Open
@vercel Vercel
Copy link

vercel bot commented May 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
slo-beaver-brigade ❌ Failed (Inspect) May 20, 2024 3:19am

javalosr2004
javalosr2004 requested changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@javalosr2004 javalosr2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Shuya! I love the effort with figuring out ways to revalidate the data, I'm wondering if we can revalidate the route, using revalidatePath("/", "layout"), I have gone ahead and made this change with dashboard, and it seems to have fixed the issue with loading signed in events!

@javalosr2004
Copy link
Collaborator

Ok I see that you fixed the navbar issue, don't worry about the refresh, I revalidated the path for /dashboard, I think one issue that remains with your implementation is, it doesn't reflect admins role correctly.

@javalosr2004
Copy link
Collaborator

Ok so I went ahead and made those changes, the thing now is we need some way of letting the user know that they are being redirected, can you make the login / verifcation button disabled while they are being redirected? Also, Aubdrey brought up an issue about forget password, it seemed that she was unable to change it.

@javalosr2004 javalosr2004 self-requested a review May 15, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javalosr2004 javalosr2004 Awaiting requested review from javalosr2004

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug Bundle #1
3 participants
@syanase-calpoly @javalosr2004 @YourUsernam3