Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability & Styling catch-all issue #122

Open
41 of 54 tasks
XuanLi-Leong opened this issue Nov 13, 2018 · 0 comments
Open
41 of 54 tasks

Usability & Styling catch-all issue #122

XuanLi-Leong opened this issue Nov 13, 2018 · 0 comments

Comments

@XuanLi-Leong
Copy link
Contributor

XuanLi-Leong commented Nov 13, 2018

Is your feature request related to a problem? Please describe.
We're lacking design conception sorry 😢

Describe the solution you'd like

WIP

RFR

Done

Legend

❗️ - BIG important change
🚧 - WIP Someone's already working on it
FE:
🦊 - QUICK FIX, please take these up they are very small tasks that just ned to be done
🌎 - Tasks that are related to site-wide stuff ("global" har har)
🔨 - Tasks that would require distinct, unrelated changes in multiple places of code. Aka feel free to open a PR that only solves the task in X file. It's still progress.
🔭 - Just needs your eyes. This is the "use our website and document any bugs you find" task.

BE

FE

Admin feature lol

  • P1: Add parents advice admin pages
  • P1: Admin page doesn’t show up in Navbar -- experiment to see when React re-renders navbar and stuff
  • 🦊Update the /admin landing - right now it looks kinda weird, do some styling to make it nicer
  • 🦊P2: Bold the username in admin upgrade

Handle edge cases

  • 🔨 Handle return values smartly, API call server errors, better error alerts, handle null/undefined variables
  • When server is down -- add a catch to all promises to return the desired structure
  • 🔨 Add empty states
  • P2: Empty state for “No quizzes” -- there is an example of empty state on the search page
  • P2: Empty state for “No books” (e.g. mistyped URL to a year we don’t have books for) -- there is an example of empty state on the search page

Polishing

  • Guide on the page regarding website, hinting users to make accounts
  • Site titles (the thing that shows up in the tab)
  • Favicon - this can wait till after talking to philareads
  • Loading screen flash can be distracting when it happens for only a fraction of a second

Usability

  • If a user is logged in, there should be an easy way to see if they have already done a quiz based on their quiz history stored in db, so that they can easily find new quizzes
  • 🦊 Badges page doesn’t show labels/ numbers for stuff that's in progress
  • 🦊 Important: Badges don’t hover text to explain what the badge is
  • 🦊When user presses login, change button to loading animation so user doesn't get confused if login takes a while
  • Change reactstrap NavLink to react-router Link components via NavLink and React Router - results in complete site reload reactstrap/reactstrap#298
  • Quiz page should collapse book information -- it's not the focus of the page
  • 🦊Changing color on focus in book selection -- probably a .css :hover property
  • 🌎 P3: Show breadcrumbs / history within each nav tab's stack of pages -- ability to easily navigate to previous page -- more context here https://www.smashingmagazine.com/2009/03/breadcrumbs-in-web-design-examples-and-best-practices/
  • 🦊 More clickability: Clicking on a book on a quiz page should bring you back to the book
  • 🦊 P1: Make entire question answer row clickable, not just the text -- just use an onClick function on the div
  • 🦊Book catalog image aligney thing -- book icon is "shorter" than a book cover image -- hotfix done but can try to do with svg
  • 🦊Pagination should visually disable back/next on first/last pages
  • If a user is on a quiz (or other) page when they click login, we should redirect them back to that page after a successful login -- either use queryparam or use this.props.state.referrer (see how we render the Login alert on Home)
  • Edit/Add another uses an <a> tag. This causes react router to re-render the entire page. We should try to use a <Link> and change how we control the state of the form / other components on the edit/add pages.
  • P2: Admin page: better way to select book (e.g. by year, text auto filter)

Styling

  • 🦊 P2: Add page title to account manage users page
  • 🦊 Search icon to RedirectSearchBar -- just gotta fight with flex a little
  • 🦊 Styling on the quiz published checkbox -- see the styling done for the book form
  • 🦊 P1: Page font size bigger + fix bootswatch border problem
  • ? Columns
  • ? Use card decks when more appropriate?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant