Fix AIs having perfect aim with rubber sniper, resolves #867

Author: Fueredoriku

Assets/Prefabs/UI/LoadingScreen.prefab

@@ -187,6 +187,8 @@ MonoBehaviour:
     see while aiming! Try combining it with an easy to aim barrel <sprite name="barrel_white">.
   - 99% of gambling addicts stop bidding right before they win a gun part in the
     auction!
+  - Some gun parts may have advantages or disadvantages on specific maps due to how
+    they work!
   transitionScreen: {fileID: 3396547481487014123}
   mandatoryDuration: 4
   normalRotationSpeed: 60

Assets/Prefabs/UI/Scoreboards.prefab

@@ -111,6 +111,10 @@ MonoBehaviour:
   - FOR CBT (COG AND BOLT TINKERING)
   - FOR CBT (CROSS-BROWSER TESTING)
   - FOR SINKING POINT NUMBERS
+  - FOR SINGNING DISTANCE FIELDS
+  - IN 17 OPTIMALLY PACKED SQUARES
+  - FOR HUGE STANDARD DEVIATION IN CRIME DATASET
+  - FOR BITSHIFTING THE ODDS TO THEIR FAVOR
   nextCrimeSound: {fileID: 11400000, guid: b85c2d27bf39bda4787e149b19385438, type: 2}
   victoryProgressSound: {fileID: 11400000, guid: eda79fdd8cc569c439c8c885d19dc633, type: 2}
   newCrimeDelay: 1

Assets/Scripts/Gamestate/AIManager.cs

@@ -54,7 +54,7 @@ public List<PlayerManager> TrackedPlayers
     private NavMeshEvent onLinkEnd;
     private AmmoBoxCollector ammoBoxCollector;
     private Coroutine airDisablingRoutine;
-    private bool isJumpCooldown = false;
+    private bool hasInaccurateAugment = false;
 
     private void Start()
     {
@@ -150,6 +150,9 @@ public override void SetGun(Transform offset)
         var barrel = ChoosePart(identity.Barrel, identity.Barrels, StaticInfo.Singleton.StartingBarrel);
         var extension = ChoosePart(identity.Extension, identity.Extensions, StaticInfo.Singleton.StartingExtension);
 
+        if (extension != null)
+            hasInaccurateAugment = extension.id == "Rubber";
+
         var gun = GunFactory.InstantiateGunAI(body, barrel, extension, this, offset);
         gunController = gun.GetComponent<GunController>();
         gunController.Initialize();
@@ -220,8 +223,10 @@ private void UpdateAimTarget(GunStats stats)
     {
         if (!ShootingTarget)
             return;
+
+        var badAimMultiplier = hasInaccurateAugment ? 4f : 1f;
         gunController.target = ShootingTarget.position
-            + new Vector3(Random.Range(-1f, 1f), 0, Random.Range(-1f, 1f))
+            + new Vector3(Random.Range(-1f, 1f) * badAimMultiplier, 0, Random.Range(-1f, 1f) * badAimMultiplier)
                 * (transform.position - ShootingTarget.position).magnitude * 0.1f;
     }
 
@@ -284,7 +289,7 @@ private void FindPlayers()
             // TODO do not default to shooting target??? what's this for?
             aiMovement.Target = ShootingTarget;
             var isStrafeDistance = closestDistance < 10f;
-            aiMovement.enabled = isStrafeDistance && !agent.currentOffMeshLinkData.activated && !isJumpCooldown;
+            aiMovement.enabled = isStrafeDistance && !agent.currentOffMeshLinkData.activated;
 
             if (ShootingTarget != null)
             {
@@ -379,7 +384,7 @@ private void AnimateJump()
         {
             OffMeshLinkData offMeshLinkData = agent.currentOffMeshLinkData;
 
-            if (offMeshLinkData.activated && !isJumpCooldown)
+            if (offMeshLinkData.activated)
             {
                 var distance = Vector3.Distance(offMeshLinkData.startPos, offMeshLinkData.endPos);
                 if (offMeshLinkData.linkType != OffMeshLinkType.LinkTypeDropDown)
@@ -392,13 +397,6 @@ private void AnimateJump()
         }
     }
 
-    private IEnumerator JumpCoolDown()
-    {
-        isJumpCooldown = true;
-        yield return new WaitForSeconds(1f);
-        isJumpCooldown = false;
-    }
-
     private void AnimateStopCrouch()
     {
         animator.SetBool("Crouching", false);