Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with filtering long text in Admin Notes filter pop-up #2043

Open
5 tasks
entrotech opened this issue Jan 16, 2025 · 2 comments
Open
5 tasks

Fix problem with filtering long text in Admin Notes filter pop-up #2043

entrotech opened this issue Jan 16, 2025 · 2 comments

Comments

@entrotech
Copy link
Member

entrotech commented Jan 16, 2025

Overview

In the pop-up for filtering the Admin Notes column on the My Projects page, if there are some admin notes that contain a lot of text, the list within the pop-up has terrible formatting - see References,

Action Items

  • Limit the length of the text in each list item by truncating the text (possibly starting with the text that matches the "filter by" search string). See Bonnie's comment below for suggestion.
  • Review with product and dev. Update if needed based on feedback
  • Once finalized, add before and after images to the staging deck on this slide
  • Get Stakeholder sign-off via the stakeholder meeting slide deck.

Resources/Instructions

Image

@ExperimentsInHonesty
Copy link
Member

Notes from #1651

We reviewed the changes you made today at the Stakeholder prep meeting. The list of checkboxes in the filter will need to have a constraint added to it, so that it only shows 28 characters total. If the note is longer than 28 characters, show 25 followed by "..."

image

The reason for this, is to prevent wrapping, which had a variety of unintended consequences

  1. the checkbox got small
  2. the words could potentially wrap for quite a while
  3. the text was displaying over other text

@entrotech entrotech moved this from New Issue Approval to Prioritized Backlog in P: TDM: project board Jan 16, 2025
@thetanmancan
Copy link
Member

Hi @entrotech. Is the 25-character limit detailed in the comment above determined by the actual amount of characters regardless of the size of the character? Or will there be a different metric used to determine the filter overlay's width, such as ems or rems or pixels? Please let me know so that I can make note of this in our style guide. Thank you.

@ExperimentsInHonesty ExperimentsInHonesty added this to the 10 - Launch milestone Jan 22, 2025
@ExperimentsInHonesty ExperimentsInHonesty moved this from Prioritized Backlog to New Issue Approval in P: TDM: project board Jan 22, 2025
@ExperimentsInHonesty ExperimentsInHonesty moved this from New Issue Approval to Prioritized Backlog in P: TDM: project board Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Prioritized Backlog
Development

No branches or pull requests

3 participants