Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SoGoSurvey credit reference to the credit page for the Design Systems team #2936

Closed
2 of 3 tasks
JeannyRen opened this issue Mar 7, 2022 · 25 comments
Closed
2 of 3 tasks
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Credit https://www.hackforla.org/credits/ ready for design lead role: design size: 0.5pt Can be done in 3 hours or less

Comments

@JeannyRen
Copy link
Member

JeannyRen commented Mar 7, 2022

Overview

The Design Systems team will have access to SoGoSurvey's Plus plan for free. In order for them to have this access they need a SoGoSurvey credit reference on the credits webpage.

Action Items

  • Add SoGoSurvey credit code (see in resources) to the credit webpage
    • Mention the Design Systems team as part of the credit

Merge Team

  • Once merged, inform the Design System's PM or one of the UXR Leads. They need to provide a print screen in order to access the Plus plan.

Resources/Instructions

Please use this provided code for the credit (without modification):

<a style="text-decoration: none;" href="https://www.sogosurvey.com/" target="_blank">Online Surveys powered by SoGoSurvey<br /><img style="border: none;" src="https://www.sogosurvey.com/static/ONLINE-SURVEY-IMAGES/ONLINE-SURVEYS-COMMON/logoM.png" alt="Provided by SoGoSurvey" /></a> 

Figma, Credits page

@github-actions

This comment was marked as resolved.

@github-actions github-actions bot added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Mar 7, 2022
@JeannyRen

This comment was marked as resolved.

@allthatyazz

This comment was marked as outdated.

@JessicaLucindaCheng JessicaLucindaCheng added role: front end Tasks for front end developers P-Feature: Credit https://www.hackforla.org/credits/ size: 0.5pt Can be done in 3 hours or less Complexity: Small Take this type of issues after the successful merge of your second good first issue and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Mar 8, 2022
@JessicaLucindaCheng

This comment was marked as resolved.

@JeannyRen

This comment was marked as outdated.

@ExperimentsInHonesty

This comment was marked as outdated.

@Providence-o Providence-o added Dependency An issue is blocking the completion or starting of another issue role: design and removed role: front end Tasks for front end developers labels Mar 10, 2022
@JeannyRen

This comment was marked as outdated.

@allthatyazz

This comment was marked as outdated.

@hangjoyce

This comment was marked as outdated.

@ExperimentsInHonesty

This comment was marked as outdated.

@github-actions github-actions bot added the Status: Updated No blockers and update is ready for review label Mar 18, 2022
@ExperimentsInHonesty
Copy link
Member

@JeannyRen we have the designer you sent us working on this.

@JeannyRen

This comment was marked as outdated.

@Providence-o
Copy link
Contributor

Providence-o commented Mar 23, 2022

@hangjoyce Thank you for the work on the credits page. Let's see if we can't get the vendor to agree to what we have provided before we have you do a different version.

@JeannyRen Can go back to them and see if you can't get them to agree to the below layout. See details below:

We will not be able to use the HTML as specified because it does not fit with our compliance requirements for WCAG. Specifically, it has alt text which is redundant to the copy being provided, which not recommended by current guidance. And the image is purely decorative, which also calls for empty alt tags.

Additionally, we would prefer to provide the information in the format we have specified below (that matches our design system), so that people can see exactly how the resource is being used. The "By" line would grow as more Hack for LA teams use it.

Here is what we recommend as being appropriate to their intention, while keeping with our Page Design.
image


Accessibility standards
Title III of the Americans with Disabilities Act (ADA) requires that all websites be accessible to people with disabilities. The World Wide Web (W3C) Consortium's Web Content Accessibility Guidelines (WCAG) 2.0 Level AA function as the current legal standard for website accessibility.

Get acquainted with accessibility: https://www.ada.gov/pcatoolkit/chap5toolkit.htm

When to have an empty alt tag

@github-actions github-actions bot added 2 weeks inactive and removed Status: Updated No blockers and update is ready for review labels Mar 25, 2022
@github-actions

This comment was marked as outdated.

@JeannyRen
Copy link
Member Author

@hangjoyce Thank you so much for your help!!!!!! You have helped a lot with speeding up this process. It is much appreciated. I will remove the update label for you. You can ignore the github-bot.

@JeannyRen
Copy link
Member Author

Update @Providence-o :

Thank you for the update. I have gotten back to them. Thank you also for providing the reasoning behind the design decisions. That was very useful. Let's see what happens :-)

@JeannyRen
Copy link
Member Author

@Providence-o, @ExperimentsInHonesty, @allthatyazz. The SoGoSurvey platform team has approved the credit reference as is. So we can proceed :-)

@phuonguvan
Copy link
Member

@JeannyRen Great! We'll hand this to the development team and keep you informed.

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Mar 31, 2022

@phuonguvan

Click here to see image I am referring to

image

  • The header Iconograpfy & Imagery has a typo. Iconograpfy should be Iconography.
  • Also, in the credit itself (on the bottom), is the red text Design System's Team and SoGoSurvey supposed to be links?
    • If yes, should they be underlined like the other links on the page?

@hangjoyce
Copy link
Member

@JessicaLucindaCheng Hi Jessica, I was the designer of this issue. Thank you for pointing out the typo and the link, I fixed it. You can find the design in Hack for LA Website Figma file > Issac's Page > Credit Page. The new design (both web and mobile ver) is in the blue box on the Credit Page. Please let me know if you had problem finding it.

@JeannyRen
Copy link
Member Author

@cunninghamej Hereby the process with regards to the access to the SoGoSurvey Plus program. Once the reference is online I can contact the SoGoSurvey team and include the necessary details :-)

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Apr 3, 2022

Link to the development issue for adding SoGoSurvey to the Credits page: #3022

@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented May 5, 2022

@phuonguvan We need to make a new issue for copying The finished design
from Figma, Credits page

to the Figma, Current Pages

See Figma Housekeeping, Current pages for details

Once the new issue is made, go ahead and link it in a comment below and then move this issue into Done column.

@ExperimentsInHonesty ExperimentsInHonesty added ready for design lead and removed time sensitive Needs to be worked on by a particular timeframe labels May 5, 2022
@ExperimentsInHonesty
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Credit https://www.hackforla.org/credits/ ready for design lead role: design size: 0.5pt Can be done in 3 hours or less
Projects
Development

No branches or pull requests

7 participants