-
-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SoGoSurvey credit reference to the credit page for the Design Systems team #2936
Comments
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@JeannyRen we have the designer you sent us working on this.
|
This comment was marked as outdated.
This comment was marked as outdated.
@hangjoyce Thank you for the work on the credits page. Let's see if we can't get the vendor to agree to what we have provided before we have you do a different version. @JeannyRen Can go back to them and see if you can't get them to agree to the below layout. See details below: We will not be able to use the HTML as specified because it does not fit with our compliance requirements for WCAG. Specifically, it has alt text which is redundant to the copy being provided, which not recommended by current guidance. And the image is purely decorative, which also calls for empty alt tags. Additionally, we would prefer to provide the information in the format we have specified below (that matches our design system), so that people can see exactly how the resource is being used. The "By" line would grow as more Hack for LA teams use it. Here is what we recommend as being appropriate to their intention, while keeping with our Page Design. Accessibility standards Get acquainted with accessibility: https://www.ada.gov/pcatoolkit/chap5toolkit.htm |
This comment was marked as outdated.
This comment was marked as outdated.
@hangjoyce Thank you so much for your help!!!!!! You have helped a lot with speeding up this process. It is much appreciated. I will remove the update label for you. You can ignore the github-bot. |
Update @Providence-o : Thank you for the update. I have gotten back to them. Thank you also for providing the reasoning behind the design decisions. That was very useful. Let's see what happens :-) |
@Providence-o, @ExperimentsInHonesty, @allthatyazz. The SoGoSurvey platform team has approved the credit reference as is. So we can proceed :-) |
@JeannyRen Great! We'll hand this to the development team and keep you informed. |
|
@JessicaLucindaCheng Hi Jessica, I was the designer of this issue. Thank you for pointing out the typo and the link, I fixed it. You can find the design in Hack for LA Website Figma file > Issac's Page > Credit Page. The new design (both web and mobile ver) is in the blue box on the Credit Page. Please let me know if you had problem finding it. |
@cunninghamej Hereby the process with regards to the access to the SoGoSurvey Plus program. Once the reference is online I can contact the SoGoSurvey team and include the necessary details :-) |
Link to the development issue for adding SoGoSurvey to the Credits page: #3022 |
@phuonguvan We need to make a new issue for copying The finished design to the Figma, Current Pages See Figma Housekeeping, Current pages for details Once the new issue is made, go ahead and link it in a comment below and then move this issue into Done column. |
|
Overview
The Design Systems team will have access to SoGoSurvey's Plus plan for free. In order for them to have this access they need a SoGoSurvey credit reference on the credits webpage.
Action Items
Merge Team
Resources/Instructions
Please use this provided code for the credit (without modification):
Figma, Credits page
The text was updated successfully, but these errors were encountered: