Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify which pages call Tools data from each project #4525

Closed
13 tasks done
Tracked by #4776 ...
Sebster3 opened this issue Apr 16, 2023 · 17 comments
Closed
13 tasks done
Tracked by #4776 ...

Identify which pages call Tools data from each project #4525

Sebster3 opened this issue Apr 16, 2023 · 17 comments
Assignees
Labels
Complexity: Large Feature: Refactor JS / Liquid Page is working fine - JS / Liquid needs changes to become consistent with other pages p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 2pt Can be done in 7-12 hours Status: Updated No blockers and update is ready for review time sensitive Needs to be worked on by a particular timeframe

Comments

@Sebster3
Copy link
Member

Sebster3 commented Apr 16, 2023

Overview

To ensure consistency with surrounding data, we need to update the formatting of tools in each project's frontmatter to a YAML array. To safely propagate this change, we must identify which pages reference the tools frontmatter data in each project's markdown file in the _projects folder.

Details

We're going to format the tools data like the technologies data, so that we can reuse some existing code. To do this safely, we need to identify which files need updating.

Action Items

  • Observe the existing syntax of the front matter block inside many of the markdown files in the _projects folder and find the tools variable. As an example, access-the-data.md includes tools in its frontmatter.
  • Identify which pages make a reference to, or otherwise query, the tools data stored in the project files, and then trace to the base file with the logic for displaying the data. Examples include but are not limited to:
  • Document your findings in a Google Doc in the "HackForLA.org" Google Drive
    • Document how those pages and related file(s) make use of the tools data.
    • Document the effects to the current pages when the tools data is saved as a yml list, then
    • Document the necessary changes that must be made to each page and the related file(s) to ensure that the current implementation and rendering are not broken when the formatting of the data changes.
      This will require careful analysis of the current code which uses the tools data to ensure it does not break when provided an array of data instead of a single string.
    • Link the Doc in the Resources/Instructions section below.
  • Discuss your findings with the dev lead(s) and PM(s).

For Merge Team/Tech Leads/PMs:

Resources/Instructions

  • Markdown Frontmatter
  • Project files: _projects
  • Add link here to the document identifying each page that: uses the Tools data, and what changes need to be made
@Sebster3 Sebster3 added the Draft Issue is still in the process of being created label Apr 16, 2023
@github-actions github-actions bot added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing labels Apr 16, 2023
@github-actions

This comment was marked as outdated.

@Sebster3 Sebster3 added Complexity: Medium role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers size: 2pt Can be done in 7-12 hours Feature: Refactor JS / Liquid Page is working fine - JS / Liquid needs changes to become consistent with other pages p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly ready for dev lead Issues that tech leads or merge team members need to follow up on and removed Complexity: Missing Feature Missing This label means that the issue needs to be linked to a precise feature label. Draft Issue is still in the process of being created labels Apr 29, 2023
@jdingeman

This comment was marked as outdated.

@Sebster3

This comment was marked as outdated.

@roslynwythe

This comment was marked as outdated.

@Sebster3

This comment was marked as outdated.

@ExperimentsInHonesty

This comment was marked as resolved.

@ExperimentsInHonesty ExperimentsInHonesty added the time sensitive Needs to be worked on by a particular timeframe label May 14, 2023
@t-will-gillis

This comment was marked as resolved.

@ExperimentsInHonesty

This comment was marked as resolved.

@ExperimentsInHonesty ExperimentsInHonesty added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed Ready for Prioritization labels May 23, 2023
@Sebster3

This comment was marked as resolved.

@ExperimentsInHonesty

This comment was marked as resolved.

@93Belen 93Belen self-assigned this Jun 4, 2023
@github-actions
Copy link

github-actions bot commented Jun 4, 2023

Hi @93Belen, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@93Belen 93Belen removed their assignment Jun 4, 2023
@ronaldpaek
Copy link
Member

i. Availability: 6/11 - 6/13
ii. ETA: Not sure when I will finish, am I never done a task this big, 6/13, if not hopefully the next week will check in and ask for help if I run any blockers

@ronaldpaek ronaldpaek self-assigned this Jun 8, 2023
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Hi @ronaldpaek, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@ronaldpaek
Copy link
Member

  1. 6/13/23
  2. 6/13/23

Hello I am not sure how to proceed, I made a google docs, but not 100% if I wrote this correctly and not sure how to upload it to hack4la google drive and where to place it.

https://docs.google.com/document/d/1IEazMdDmDd86SUoQEBduKCsfOgUBnEZQKOM_ZPBnrCI/edit?usp=sharing

@ronaldpaek ronaldpaek added the Status: Updated No blockers and update is ready for review label Jun 13, 2023
@github-actions
Copy link

Hi @t-will-gillis, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@ronaldpaek
Copy link
Member

@t-will-gillis tagging you, please let me know what I should do, I wasn't sure how to create a PR for this

@t-will-gillis
Copy link
Member

Hey @ronaldpaek - your report looks great! It identifies:

  • the 17 +/- markdown files in the /_projects/ folder that include the tools data,
  • the proposed refactoring of the code in the project.html file to use the newly formatted tools,
  • the proposed refactoring of the code in the current-projects.js file to use the newly formatted tools, and
  • the proposed refactoring of the code in the current-projects-check.js file to use the newly formatted tools.

I am closing this issue as completed, and releasing the dependency on the next issue. Thank you for your work on this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Large Feature: Refactor JS / Liquid Page is working fine - JS / Liquid needs changes to become consistent with other pages p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 2pt Can be done in 7-12 hours Status: Updated No blockers and update is ready for review time sensitive Needs to be worked on by a particular timeframe
Projects
Development

No branches or pull requests

7 participants