Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update chip labels from plural to singular #4647

Closed
8 tasks done
Tracked by #4648
christinaor opened this issue May 10, 2023 · 14 comments · Fixed by #6271
Closed
8 tasks done
Tracked by #4648

Update chip labels from plural to singular #4647

christinaor opened this issue May 10, 2023 · 14 comments · Fixed by #6271
Assignees
@irais-valenzuela
Labels
Complexity: Medium P-Feature: Projects page https://www.hackforla.org/projects/ role: front end Tasks for front end developers size: 2pt Can be done in 7-12 hours
Milestone
03.02 Onboarding ...

Comments

@christinaor
Copy link
Member

christinaor commented May 10, 2023 •
edited by elliot-d-kim
Loading

Dependency

Overview

Currently, chip label prefixes for the "Technologies" and "Tools" filter groups are pluralized even if only one filter item is listed under the label. This can be confusing to users, so we want to update the chip label prefixes to "Technology" and "Tool"

Action Items

Resources/Instructions
@christinaor christinaor added role: front end Tasks for front end developers Complexity: Medium P-Feature: Projects page https://www.hackforla.org/projects/ ready for dev lead Issues that tech leads or merge team members need to follow up on size: 2pt Can be done in 7-12 hours labels May 10, 2023
@christinaor christinaor mentioned this issue May 10, 2023
Closed
4 tasks
@Gauravvpnd

This comment was marked as resolved.

Sign in to view
@christinaor christinaor mentioned this issue May 10, 2023
Closed
5 tasks
@christinaor

This comment was marked as resolved.

Sign in to view
@wanyuguan wanyuguan added this to the 03.02 Onboarding flow milestone May 14, 2023
@ExperimentsInHonesty

This comment was marked as outdated.

Sign in to view
@roslynwythe roslynwythe added the Dependency An issue is blocking the completion or starting of another issue label Oct 15, 2023
@roslynwythe

This comment was marked as outdated.

Sign in to view
@roslynwythe roslynwythe removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Oct 15, 2023
@LukeLowrey2 LukeLowrey2 self-assigned this Jan 10, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@LukeLowrey2

This comment was marked as outdated.

Sign in to view
@LukeLowrey2

This comment was marked as outdated.

Sign in to view
@LukeLowrey2

This comment was marked as outdated.

Sign in to view
@LukeLowrey2 LukeLowrey2 removed their assignment Jan 23, 2024
@ExperimentsInHonesty ExperimentsInHonesty removed the Dependency An issue is blocking the completion or starting of another issue label Jan 28, 2024
@irais-valenzuela irais-valenzuela self-assigned this Feb 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024

Hi @irais-valenzuela, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@irais-valenzuela
Copy link
Member

irais-valenzuela commented Feb 5, 2024 •
edited
Loading

Availability for this week: Monday, Tuesday, Thursday 11am - 4pm
My estimated ETA for completing this issue: Thursday

@irais-valenzuela
Copy link
Member

Hello, I have a blocker more like a question. I've updated the chip label names (the variable filterName) in the filterTagComponent function in assests/js/currentProjects.js from "technologies" and "tools" to singular names of "technology" and "tool". The change is also reflected in the UI as well.

Here's the code for it:
function filterTagComponent(filterName,filterValue){ // made a copy of filterName let copyOfFilterName = filterName // copyOfFilterName getting reasssigned to either "tool" or "technology" using it later within span tag if (copyOfFilterName === "tools") copyOfFilterName = "tool" else if (copyOfFilterName === "technologies") copyOfFilterName = "technology" return



${filterName === "looking" ? "Role" : copyOfFilterName.length > 0 ? copyOfFilterName : filterName}: ${filterValue}

}

I'm curious if I also have to change the data-filter attribute in the div to also have the singular label name of either "technology" or "tool" or if I should leave that as the plural form of technology and tool. The branch I'm working on is called "plural-to-singular-chip-labels-4647" if needed.

Any assistance is appreciated. Thank you.

@roslynwythe
Copy link
Member

@irais-valenzuela Assuming you have tested the filters and everything works fine, you don't have to change the data-filter attribute. But thanks for checking!

@irais-valenzuela
Copy link
Member

irais-valenzuela commented Feb 8, 2024 •
edited
Loading

Hi, I'm trying to finish testing my changes on my localhost but I'm unable to start the server. I keep getting errors like this:
`> [+] Running 1/0

✔ Container hfla_site Created 0.0s
Attaching to hfla_site
hfla_site | ruby 2.7.4p191 (2021-07-07 revision a21a3b7d23) [x86_64-linux-musl]
hfla_site | Configuration file: /srv/jekyll/_config.yml
hfla_site | Cleaner: Removing /srv/jekyll/_site...
hfla_site | Cleaner: Removing ./.jekyll-metadata...
hfla_site | Cleaner: Nothing to do for .sass-cache.
hfla_site | ruby 2.7.4p191 (2021-07-07 revision a21a3b7d23) [x86_64-linux-musl]
hfla_site | Configuration file: _config.yml
hfla_site | Configuration file: _config.docker.yml
hfla_site | Source: .
hfla_site | Destination: /srv/jekyll/_site
hfla_site | Incremental build: enabled
hfla_site | Generating...
hfla_site | Liquid Exception: Liquid syntax error (line 112): Tag '{% - for project in visible_projects -%}' was not properly terminated with regexp: /%}/ in assets/js/current-projects.js
hfla_site | jekyll 3.9.2 | Error: Liquid syntax error (line 112): Tag '{% - for project in visible_projects -%}' was not properly terminated with regexp: /%}/
hfla_site | /usr/gem/gems/liquid-4.0.3/lib/liquid/block_body.rb:132:in raise_missing_tag_terminator': Liquid syntax error (line 112): Tag '{% - for project in visible_projects -%}' was not properly terminated with regexp: /\\%\\}/ (Liquid::SyntaxError) hfla_site | from /usr/gem/gems/liquid-4.0.3/lib/liquid/block_body.rb:24:in parse'
hfla_site | from /usr/gem/gems/liquid-4.0.3/lib/liquid/document.rb:10:in parse' hfla_site | from /usr/gem/gems/liquid-4.0.3/lib/liquid/document.rb:5:in parse'
hfla_site | from /usr/gem/gems/liquid-4.0.3/lib/liquid/template.rb:132:in parse' hfla_site | from /usr/gem/gems/liquid-4.0.3/lib/liquid/template.rb:116:in parse'
hfla_site | from /usr/gem/gems/jekyll-3.9.2/lib/jekyll/liquid_renderer/file.rb:13:in block in parse' hfla_site | from /usr/gem/gems/jekyll-3.9.2/lib/jekyll/liquid_renderer/file.rb:49:in measure_time'
hfla_site | from /usr/gem/gems/jekyll-3.9.2/lib/jekyll/liquid_renderer/file.rb:12:in parse' hfla_site | from /usr/gem/gems/jekyll-3.9.2/lib/jekyll/renderer.rb:121:in render_liquid'
hfla_site | from /usr/gem/gems/jekyll-3.9.2/lib/jekyll/renderer.rb:79:in render_document' hfla_site | from /usr/gem/gems/jekyll-3.9.2/lib/jekyll/renderer.rb:62:in run'
hfla_site | from /usr/gem/gems/jekyll-3.9.2/lib/jekyll/site.rb:479:in render_regenerated' hfla_site | from /usr/gem/gems/jekyll-3.9.2/lib/jekyll/site.rb:472:in block in render_pages'
hfla_site | from /usr/gem/gems/jekyll-3.9.2/lib/jekyll/site.rb:471:in each' hfla_site | from /usr/gem/gems/jekyll-3.9.2/lib/jekyll/site.rb:471:in render_pages'
hfla_site | from /usr/gem/gems/jekyll-3.9.2/lib/jekyll/site.rb:192:in render' hfla_site | from /usr/gem/gems/jekyll-3.9.2/lib/jekyll/site.rb:71:in process'
hfla_site | from /usr/gem/gems/jekyll-3.9.2/lib/jekyll/command.rb:28:in process_site' hfla_site | from /usr/gem/gems/jekyll-3.9.2/lib/jekyll/commands/build.rb:65:in build'
hfla_site | from /usr/gem/gems/jekyll-3.9.2/lib/jekyll/commands/build.rb:36:in process' hfla_site | from /usr/gem/gems/jekyll-3.9.2/lib/jekyll/commands/serve.rb:93:in block in start'
hfla_site | from /usr/gem/gems/jekyll-3.9.2/lib/jekyll/commands/serve.rb:93:in each' hfla_site | from /usr/gem/gems/jekyll-3.9.2/lib/jekyll/commands/serve.rb:93:in start'
hfla_site | from /usr/gem/gems/jekyll-3.9.2/lib/jekyll/commands/serve.rb:75:in block (2 levels) in init_with_program' hfla_site | from /usr/gem/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in block in execute'
hfla_site | from /usr/gem/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in each' hfla_site | from /usr/gem/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in execute'
hfla_site | from /usr/gem/gems/mercenary-0.3.6/lib/mercenary/program.rb:42:in go' hfla_site | from /usr/gem/gems/mercenary-0.3.6/lib/mercenary.rb:19:in program'
hfla_site | from /usr/gem/gems/jekyll-3.9.2/exe/jekyll:15:in <top (required)>' from /usr/gem/bin/jekyll:25:in load'
from /usr/gem/bin/jekyll:25:in <main>' hfla_site exited with code 1

This is the main error: Liquid Exception: Liquid syntax error (line 112): Tag '{% - for project in visible_projects -%}' was not properly terminated with regexp: /%}/ in assets/js/current-projects.js
Any assistance is appreciated. Thank you.

@irais-valenzuela irais-valenzuela mentioned this issue Feb 9, 2024
Merged
@irais-valenzuela
Copy link
Member

Availability for this week: Thursday 1pm - 6pm, Friday 11am-4pm
My estimated ETA for completing this issue: Friday

t-will-gillis pushed a commit that referenced this issue Feb 15, 2024
@irais-valenzuela
Changed "technologies" and "tools" chip labels to singular chip label…
7ce3ea0 
…s (technology and tool) - #4647 (#6271)

* changed chip labels from plural to singular labels

* added if else logic directly on the variable name
This was referenced Feb 15, 2024
Closed
Closed
Closed
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irais-valenzuela irais-valenzuela

Labels
Complexity: Medium P-Feature: Projects page https://www.hackforla.org/projects/ role: front end Tasks for front end developers size: 2pt Can be done in 7-12 hours
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
03.02 Onboarding flow
7 participants
@roslynwythe @wanyuguan @ExperimentsInHonesty @christinaor @LukeLowrey2 @irais-valenzuela @Gauravvpnd