-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor HTML and JavaScript so projects and projects-check pages can share the same files #4960
Comments
We think this is feasible, so this issue will get rewritten to be a large, get it done issue. But it will also the following dependencies |
|
Hi @jphamtv, thank you for taking up this issue! Hfla appreciates you :) Do let fellow developers know about your:- You're awesome! P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :) |
Availability: Monday-Friday 12–2 PM, 8–10 PM (PST) |
PR created #5978 Hi @roslynwythe - FYI I didn’t delete |
Dependencies
Overview
We need to refactor the HTML and JavaScript for the Projects and Projects-Check pages, so that both pages share the same HTML and JavaScript files. The differences in filter options between the two pages will be implemented by adding conditional logic in JavaScript based on the current page URL.
Details
Action Items
_pages/projects-check.html
so that it includescurrent-projects.html
instead ofcurrent-projects-check.html
. As a result of this change, the projects-check page will reference the same HTML include and same JavaScript as the projects page./assets/js/current-projects-check.js
and/assets/js/current-projects.js
. For each difference, determine if the difference is required to implement the distinct filter options required on the Projects-Check page.Resources/Instructions
The text was updated successfully, but these errors were encountered: