Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ER: Modify JavaScript so Ruby and Svelte are included in the Filter on Projects page #6274

Closed
2 of 7 tasks
jphamtv opened this issue Feb 10, 2024 · 2 comments
Closed
2 of 7 tasks
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue ER Emergent Request P-Feature: Home page https://www.hackforla.org/ P-Feature: Projects page https://www.hackforla.org/projects/ ready for dev lead Issues that tech leads or merge team members need to follow up on role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Milestone

Comments

@jphamtv
Copy link
Member

jphamtv commented Feb 10, 2024

Emergent Requirement - Problem

Ruby and Svelte languages are being excluded from the 'Languages / Technologies' filter on the Project page.

Issue you discovered this emergent requirement in

Date discovered

12-27-23

Did you have to do something temporarily

  • YES
  • NO

Who was involved

@t-will-gillis

What happens if this is not addressed

Users will not be able to filter projects by Ruby language or Svelte framework. This may be a minor issue since the related projects are not currently active.

Resources

assets/js/current-projects.js
Projects page
Home page
See comments where the issue was found

Recommended Action Items

  • Make a new issue
  • Discuss with team
  • Let a Team Lead know

Potential solutions [draft]

Modify the code so they are included in the 'Languages / Technologies' filter on the Projects and Home pages.

Action Items

  • Replace the following code:
'technologies': [...new Set(sortedProjectData.map(item => (item.project.technologies && item.project.languages?.length > 0) ? [item.project.languages, item.project.technologies].flat() : '').flat() ) ].filter(v=>v!='').sort(),
  • With:
'technologies': [
    ...new Set(
        sortedProjectData.map(item => {
            let combined = [];
            if (item.project.languages?.length > 0) {
                combined = combined.concat(item.project.languages);
            }
            if (item.project.technologies?.length > 0) {
                combined = combined.concat(item.project.technologies);
            }
            return combined;
        }).flat()
    )
].filter(v => v).sort(),
@jphamtv jphamtv added role: front end Tasks for front end developers P-Feature: Home page https://www.hackforla.org/ Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Projects page https://www.hackforla.org/projects/ ready for dev lead Issues that tech leads or merge team members need to follow up on size: 0.25pt Can be done in 0.5 to 1.5 hours ER Emergent Request labels Feb 10, 2024
@jphamtv
Copy link
Member Author

jphamtv commented Feb 10, 2024

Hi @ExperimentsInHonesty - I've prepared the ER you requested. As discussed in last Monday's meeting, I created the issue before understanding the correct process order (ER first, then create an Issue if approved). If this ER is approved, the issue is ready at #6071.

@roslynwythe
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue ER Emergent Request P-Feature: Home page https://www.hackforla.org/ P-Feature: Projects page https://www.hackforla.org/projects/ ready for dev lead Issues that tech leads or merge team members need to follow up on role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Development

Successfully merging a pull request may close this issue.

3 participants