Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify where the label: ready for dev lead is being used #6783

Closed
6 of 7 tasks
ExperimentsInHonesty opened this issue Apr 29, 2024 · 6 comments
Closed
6 of 7 tasks
Assignees
Labels
Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours

Comments

@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Apr 29, 2024

Overview

We need to document where the ready for dev lead label is referenced so that we can make a plan to change some of the issues and GHAs to use ready for merge team instead.

Action Items

  • Create a spreadsheet called Ready for merge team and dev lead rationalization, in the folder (Resource 1.01) and add the link to Resource 2.01 below
  • Add the following columns
    • Column 1: location
    • Column 2: location_type
    • Column 3: merge_team_can_handle
    • Column 4: notes
  • Identify all the places that there are references to ready for dev lead (Resource 1.02) and add the URL into column 1 (in the code base, should be a URL)
  • Add location type to column 2 (GHA, WIKI, Issue Template, open issues)
  • Add a note to indicate what the purpose of the ready for dev lead label is
  • Move this issue to the Questions column and add the Ready for dev lead label

Merge team action items

Resources/Instructions

Resources for creating this issue

Resources gathered during the completion of this issue

@ExperimentsInHonesty ExperimentsInHonesty added Feature Missing This label means that the issue needs to be linked to a precise feature label. size: missing Draft Issue is still in the process of being created role missing Complexity: Missing labels Apr 29, 2024
@ExperimentsInHonesty ExperimentsInHonesty changed the title Change the label ready for dev lead to ready for merge team Identify where the labels that say ready for dev lead should be changed to ready for merge team Apr 29, 2024
@ExperimentsInHonesty ExperimentsInHonesty added Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours and removed Draft Issue is still in the process of being created Complexity: Missing Feature Missing This label means that the issue needs to be linked to a precise feature label. size: missing role missing labels Apr 29, 2024
@ExperimentsInHonesty ExperimentsInHonesty changed the title Identify where the labels that say ready for dev lead should be changed to ready for merge team Identify where the labels that say ready for dev lead are being used Apr 30, 2024
@urvishp13 urvishp13 self-assigned this Apr 30, 2024

This comment was marked as outdated.

@urvishp13
Copy link
Member

Availability: 1-4pm 4/30/24, 12-3pm 5/2/24
ETA: End of this week

@urvishp13 urvishp13 added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Apr 30, 2024
@ExperimentsInHonesty
Copy link
Member Author

ExperimentsInHonesty commented Apr 30, 2024

@urvishp13 I just checked out the spreadsheet and I have the following notes

FYI - I changed some formatting and some content

For background information about good spreadsheet formatting, see https://github.com/hackforla/product-management/wiki/Google-Sheets

  • changed the column header from notes to notes_summary (I really liked how succinct you were in your notes, and I want to keep that).
  • added the column header notes_detail (I added this column, so I could write my review and share it with the merge team)
  • On some of your notes_summary, changed
    • from: review the completed template once issue is submitted
    • to: review the issue created from the template
  • added data validation to two columns: merge_team_can_handle and location_type
  • froze the top row, so that it would stay visible when you scroll down
  • wrapped the content in all the columns, so that if it overflows the content does not get cut off
  • top aligned the whole sheet, then bottom aligned the top row
  • removed the extra rows to the right
  • removed extra rows at bottom, but left you 110 rows for the open issues and wiki you will be adding

Please make these changes

  • replace the commit number in the URLs with gh-pages
  • add the open issues that the issue asks for
    • of the 98 issues I see when I go there, you can add the following notes to all the Resolve CodeQL Alert issues
      • notes_summary:
        recommendation to dismiss the alert
        
      • notes_detail:
        later if we decide Merge Team can handle this, it will need to be changed manually on this open issue, but will be addressed for future alerts by changing /github-actions/trigger-issue/create-codeql-issues/issue-body.md?plain=1#L13 if necessary.
        
  • add the wiki pages that the issue asks for

@ExperimentsInHonesty ExperimentsInHonesty removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Apr 30, 2024
@ExperimentsInHonesty ExperimentsInHonesty changed the title Identify where the labels that say ready for dev lead are being used Identify where the label: ready for dev lead is being used Apr 30, 2024
@urvishp13
Copy link
Member

@ExperimentsInHonesty I have made the requested additions/changes. There were 2 queries of the 98 issues in the link you provided that didn't have anything to do with the ready for dev lead label so I didn't put them in the spreadsheet.

@urvishp13 urvishp13 added the ready for dev lead Issues that tech leads or merge team members need to follow up on label May 2, 2024
@urvishp13
Copy link
Member

Blocker: @roslynwythe can you close this issue as discussed in last Thursday's meeting.

@urvishp13 urvishp13 added the Status: Help Wanted Internal assistance is required to make progress label May 14, 2024
@roslynwythe
Copy link
Member

Thank you @urvishp13 for compiling the spreadsheet

@Thinking-Panda Thinking-Panda removed the Status: Help Wanted Internal assistance is required to make progress label May 22, 2024
@t-will-gillis t-will-gillis removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours
Development

No branches or pull requests

5 participants