Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance for "Update Label Directory" workflow #7563

Closed
3 tasks done
t-will-gillis opened this issue Oct 4, 2024 · 3 comments · Fixed by #7599
Closed
3 tasks done

Maintenance for "Update Label Directory" workflow #7563

t-will-gillis opened this issue Oct 4, 2024 · 3 comments · Fixed by #7599
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 3pt Can be done in 13-18 hours

Comments

@t-will-gillis
Copy link
Member

t-will-gillis commented Oct 4, 2024

Overview

There are minor updates for the "Update Label Directory" workflow, one stops the automation from writing to the "Source of Truth" document when a label update does not change the label name, and the other adds a note to the console.log() for the same update.

Action Items

  • Change update-label-directory.yml for the latest Google Apps Script deployment. Replace:

     run: |
            curl -X POST "https://script.google.com/macros/s/AKfycbw_rM8kwRea_iT6NbP1k5c7nJl5qg-5IwiTPXUyd7V2Oe_TN_TbapdpcVtLPHieKdUt/exec" \
             -H "Content-Type: application/json" \
             -d "$label_edits"
    

    with:

     run: |
            curl -X POST "https://script.google.com/macros/s/AKfycbw_kmDVqQW5J8wXWl1BXvJzALU6k0XYpAc5XJ7inQSyq8_opUuNg4ToBzh3Gf4M5jhw/exec" \
             -H "Content-Type: application/json" \
             -d "$label_edits"
    
    
  • Change update-label-directory.js so that the console.log() identifies the label that is being edited. In the if (labelAction === 'edited' && !context.payload.changes.name) statement:

        console.log(`What was changed:`);
    

    with:

        console.log(`${labelName} label changed:`);
    
  • Although this is a GitHub Action, testing is not required.

Resources/Instructions

@t-will-gillis t-will-gillis added role: back end/devOps Tasks for back-end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 3pt Can be done in 13-18 hours labels Oct 4, 2024
@github-project-automation github-project-automation bot moved this to New Issue Approval in P: HfLA Website: Project Board Oct 4, 2024
@theogguu theogguu self-assigned this Oct 19, 2024
@HackforLABot
Copy link
Contributor

Hi @theogguu, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@theogguu
Copy link
Member

theogguu commented Oct 19, 2024

Availability: Sat > next Fri, starting 10/19
ETA: 10/19 EOD (today)

@t-will-gillis
Copy link
Member Author

Hi @theogguu Since you are working on this, please change the issue status to "In progress (actively working)".

Thanks!

@theogguu theogguu moved this from Prioritized backlog to In progress (actively working) in P: HfLA Website: Project Board Oct 21, 2024
@github-project-automation github-project-automation bot moved this from In progress (actively working) to QA in P: HfLA Website: Project Board Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 3pt Can be done in 13-18 hours
Projects
Development

Successfully merging a pull request may close this issue.

4 participants