Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time sensitive edits to "Schedule Monthly" workflow #7682

Closed
2 tasks
t-will-gillis opened this issue Nov 1, 2024 · 1 comment · Fixed by #7683
Closed
2 tasks

Time sensitive edits to "Schedule Monthly" workflow #7682

t-will-gillis opened this issue Nov 1, 2024 · 1 comment · Fixed by #7683
Assignees
@t-will-gillis
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms milestone: missing role: back end/devOps Tasks for back-end developers size: 0.5pt Can be done in 3 hours or less time sensitive Needs to be worked on by a particular timeframe

Comments

@t-will-gillis
Copy link
Member

Overview

There are two items on the issue for "Maintenance and adjustments to 'Schedule Monthly' workflow" that should be completed ASAP- before the review of #7614 is finalized. If these changes are not made, the Nov 1st run of "Schedule Monthly" will not correctly account for the activities of some members, and will not close the Skills Issues of some removed members.

Note that the review for the PR #7638 fixes #7614 (including these changes) will still be completed as normal.

Action Items

  • In get-contributors-data.js, the fetchContributor() function, replace conditional for if title is "Pre-work checklist" with conditional for if title is either "Pre-work checklist" or "Skills Issue"
  • In the same file, insert check for contributorInfo.created_at > date

Resources/Instructions
@t-will-gillis t-will-gillis added role: back end/devOps Tasks for back-end developers time sensitive Needs to be worked on by a particular timeframe Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 0.5pt Can be done in 3 hours or less Draft Issue is still in the process of being created labels Nov 1, 2024
@t-will-gillis t-will-gillis self-assigned this Nov 1, 2024
@github-project-automation github-project-automation bot moved this to New Issue Approval in P: HfLA Website: Project Board Nov 1, 2024
@t-will-gillis t-will-gillis moved this from New Issue Approval to In progress (actively working) in P: HfLA Website: Project Board Nov 1, 2024
@HackforLABot

This comment was marked as resolved.

Sign in to view
@t-will-gillis t-will-gillis removed the Draft Issue is still in the process of being created label Nov 1, 2024
@t-will-gillis t-will-gillis mentioned this issue Nov 1, 2024
Merged
5 tasks
@github-project-automation github-project-automation bot moved this from In progress (actively working) to QA in P: HfLA Website: Project Board Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t-will-gillis t-will-gillis

Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms milestone: missing role: back end/devOps Tasks for back-end developers size: 0.5pt Can be done in 3 hours or less time sensitive Needs to be worked on by a particular timeframe
Projects
P: HfLA Website: Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Time sensitive edits to "Schedule Monthly" t-will-gillis/website
3 participants
@ExperimentsInHonesty @t-will-gillis @HackforLABot