Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ER: Unused current-projects-check.html file #7778

Closed
3 of 5 tasks
mugdhchauhan opened this issue Nov 29, 2024 · 8 comments
Closed
3 of 5 tasks

ER: Unused current-projects-check.html file #7778

mugdhchauhan opened this issue Nov 29, 2024 · 8 comments
Assignees
@mugdhchauhan
Labels
ER Emergent Request good first issue Good for newcomers Issue Making: Level 2 Make issue(s) from an ER or Epic p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Comments

@mugdhchauhan
Copy link
Member

mugdhchauhan commented Nov 29, 2024 •
edited by t-will-gillis
Loading

Emergent Requirement - Problem

The Projects-Check page no longer uses _includes/current-projects-check.html. For conciseness and clarity it is useful to remove this unused file.

Issue you discovered this emergent requirement in

Date discovered

Nov 26 2024

Did you have to do something temporarily

  • YES
  • NO

Who was involved

@mugdhchauhan
@t-will-gillis

What happens if this is not addressed

Codebase becomes unclear and confusing.

Resources

Recommended Action Items

  • Make a new issue
  • Discuss with team
  • Let a Team Lead know

Potential solutions [draft]

Create an issue to remove the file that resolves the problem mentioned above.
@mugdhchauhan mugdhchauhan added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers size: 0.25pt Can be done in 0.5 to 1.5 hours Issue Making: Level 2 Make issue(s) from an ER or Epic ER Emergent Request labels Nov 29, 2024
@mugdhchauhan mugdhchauhan self-assigned this Nov 29, 2024
@HackforLABot HackforLABot added the Feature Missing This label means that the issue needs to be linked to a precise feature label. label Nov 29, 2024
@github-actions GitHub Actions

This comment was marked as resolved.

Sign in to view
@HackforLABot

This comment was marked as resolved.

Sign in to view
@mugdhchauhan mugdhchauhan added p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. labels Nov 29, 2024
@mugdhchauhan mugdhchauhan moved this from New Issue Approval to ERs and epics that are ready to be turned into issues in P: HfLA Website: Project Board Nov 29, 2024
@mugdhchauhan mugdhchauhan moved this from ERs and epics that are ready to be turned into issues to In progress (actively working) in P: HfLA Website: Project Board Nov 29, 2024
@mugdhchauhan mugdhchauhan added the Draft Issue is still in the process of being created label Nov 29, 2024
@mugdhchauhan
Copy link
Member Author

@t-will-gillis as per our discussion I have made this ER and the following issue:

As mentioned in my notes, the _includes/current-projects-check.html file is not used for the Projects-Check page so it can be possible to remove that entire file. I have created this issue for it (we could use this issue instead of the one I have listed above):

I can also edit the following sections of this ER to reflect this issue:

  • Title
    • ER: Unused current-projects-check.html file
  • Emergent Requirement - Problem
    • The Projects-Check page no longer uses _includes/current-projects-check.html. For conciseness and clarity it is useful to remove this unused file.
  • Potential solutions [draft]
    • Create an issue to remove the file that resolves the problem mentioned above.

Please let me know what you think is best to be done.

This was referenced Nov 29, 2024
Open
Closed
@mugdhchauhan
Copy link
Member Author

mugdhchauhan commented Nov 30, 2024 •
edited
Loading

Availability this week: Daily @ 6 PM - 8 PM (GMT)
ETA: 17 Jan 2025

@mugdhchauhan
Copy link
Member Author

mugdhchauhan commented Nov 30, 2024 •
edited
Loading

Progress Report

Provide Update

  1. Progress: Completed ER and issue making.
  2. Blockers: No blockers. Awaiting response for next steps.
  3. Availability: Daily @ 6 PM - 8 PM (GMT)
  4. ETA: 17 Jan 2025. Although, ER and relevant issues have been made and I have also proposed edits which can be used to update the ER promptly after receiving response.
  5. Pictures: No visual changes to the site.

@mugdhchauhan mugdhchauhan added the Status: Help Wanted Internal assistance is required to make progress label Nov 30, 2024
@t-will-gillis t-will-gillis removed the Status: Help Wanted Internal assistance is required to make progress label Dec 3, 2024
@t-will-gillis
Copy link
Member

@ExperimentsInHonesty @roslynwythe For your information

Hey @mugdhchauhan Thanks so much for bringing up the discrepancies in the codebase and creating this ER plus the issues.

I can also edit the following sections of this ER to reflect this issue:

  • Title
    • ER: Unused current-projects-check.html file
  • Emergent Requirement - Problem
    • The Projects-Check page no longer uses _includes/current-projects-check.html. For conciseness and clarity it is useful to remove this unused file.
  • Potential solutions [draft]
    • Create an issue to remove the file that resolves the problem mentioned above.

Thanks again for attention and work on this!

@mugdhchauhan mugdhchauhan changed the title ER: Redundant reference to current-projects-check.js in current-projects-check.html ER: Unused current-projects-check.html file Dec 3, 2024
@mugdhchauhan
Copy link
Member Author

Many thanks @t-will-gillis. I have made the edits.

@mugdhchauhan mugdhchauhan added ready for merge team needs a senior review either to do some re writing or to approve it for ready for prioritization and removed Draft Issue is still in the process of being created labels Dec 3, 2024
@mugdhchauhan mugdhchauhan moved this from In progress (actively working) to Questions / In Review in P: HfLA Website: Project Board Dec 3, 2024
@t-will-gillis
Copy link
Member

@mugdhchauhan Great thanks for making the changes.

@github-project-automation github-project-automation bot moved this from Questions / In Review to QA in P: HfLA Website: Project Board Dec 3, 2024
@t-will-gillis t-will-gillis removed the ready for merge team needs a senior review either to do some re writing or to approve it for ready for prioritization label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mugdhchauhan mugdhchauhan

Labels
ER Emergent Request good first issue Good for newcomers Issue Making: Level 2 Make issue(s) from an ER or Epic p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
P: HfLA Website: Project Board
Status: QA
Milestone
No milestone
Development

No branches or pull requests
3 participants
@t-will-gillis @mugdhchauhan @HackforLABot