Refactor GHA 'sort-closed-issues.js'

[aadilahmed]

Fixes #7530

What changes did you make?

• Imported 'retrieveLabelDirectory' function into sort-closed-issues.js
• Use 'retrieveLabelDirectory' function to replace each labelName variable with the corresponding labelKey
• Substitute the labelKey variable with each of the original label names in sort-closed-issues.js

Why did you make the changes (we will use this info to test)?

• To refactor the GHA workflows to reference each label by a general ID (labelKey) so that other HFLA groups can use these workflows without having to match the label names used by the website team

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

• I have checked this PR for CodeQL alerts and none were found.
• I found CodeQL alert(s), and (select one):
  • I have resolved the CodeQL alert(s) as noted
  • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
  • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)

Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

No visual changes to website.

Tested workflows:
move-closed-issues.yaml

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

---

From your project repository, check out a new branch and test the changes.

git checkout -b aadilahmed-refactor-gha-sort-closed-issues-7530 gh-pages
git pull https://github.com/aadilahmed/website.git refactor-gha-sort-closed-issues-7530

[ramitaarora]

Availability: Weekday mornings
ETA: Nov 21 EOD

[t-will-gillis]

Available: weekdays
ETA: Weds 11/26 eod

[daras-cu]

Hi @aadilahmed, great work on this issue. The changes you made to sort-closed-issues.js successfully retrieve the label names from the directory rather than using the hard-coded names, and the functionality is not affected. I tested closing the following issues:

• An issue with a label in hardLabels was moved to Done
• An issue with a label in softLabels was moved to Done
• An issue with a label in overrideSoftLabels was moved to QA
• An issue with none of the listed labels was moved to QA

In all cases, the GH Action performed as expected. In addition, your PR explains the changes you made and why, and links to the original issue. Well done!

[codyyjxn]

Hey @aadilahmed great job on this!

• The code is clean and concise.
• The issue is linked and the sort-closed is refactored very well.

[t-will-gillis]

Hey @aadilahmed Great job! I have tested this and everything appears to be sorting correctly. Looks great

Thanks for taking on this issue!