Skip to content
This repository has been archived by the owner on Oct 10, 2022. It is now read-only.

Create convexHull.cpp #131

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Create convexHull.cpp #131

wants to merge 4 commits into from

Conversation

harikesh409
Copy link

Fixes #77

Added implementation of the convex hull using graham's scan in c++.
Reference: http://www.dcs.gla.ac.uk/~pat/52233/slides/Hull1x1.pdf

@s-ayush2903
Copy link
Contributor

You should better add the reference in the file, so that when anyone is reading the file then they can directly go for better explanations rather searching the PR corresponding this algo implementation

s-ayush2903
s-ayush2903 suggested changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@s-ayush2903 s-ayush2903 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to Self: On hold for now, awaiting changes to be implemented, read the code again

convexHull.cpp Outdated Show resolved Hide resolved
@stale
Copy link

stale bot commented Oct 2, 2020 •
edited by s-ayush2903
Loading

It will be now be reviewed manually. Thanks for contributions. If you have more concerns, you may get the conversation started at our discord server

@stale stale bot added community and removed community labels Oct 2, 2020
@stale
Copy link

stale bot commented Oct 4, 2020

It will be now be reviewed manually. Thanks for contributions. If you have more concerns, you may get the conversation started at our discord server

@stale stale bot added the community label Oct 4, 2020
s-ayush2903
s-ayush2903 reviewed Oct 4, 2020
View reviewed changes
Copy link
Contributor

@s-ayush2903 s-ayush2903 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sync your branch with the target branch and then move this file to some appropriate folder

@stale stale bot removed the community label Oct 4, 2020
@stale
Copy link

stale bot commented Oct 5, 2020

It will be now be reviewed manually. Thanks for contributions. If you have more concerns, you may get the conversation started at our discord server

@stale stale bot added the community label Oct 5, 2020
@stale stale bot removed the community label Oct 5, 2020
@harikesh409
Copy link
Author

Please sync your branch with the target branch and then move this file to some appropriate folder

Done updated accordingly.

@stale
Copy link

stale bot commented Oct 5, 2020

It will be now be reviewed manually. Thanks for contributions. If you have more concerns, you may get the conversation started at our discord server

@stale stale bot added the community label Oct 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s-ayush2903 s-ayush2903 Awaiting requested review from s-ayush2903

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convex Hull: Graham's Scan Algorithm
2 participants
@harikesh409 @s-ayush2903