Rewrite to v2 #13
Labels
Comments
This was referenced Aug 21, 2023
Draft
franziskuskiefer
added
good first issue
W95Psp
added a commit
to hacspec/hax
that referenced
this issue
May 7, 2024
The https://github.com/hacspec/specs repository contains specifications written in hacspec, mainly at the time of hacspec v1. Since hacspec v1 is deprecated and archived, its library is deprecated as well. The hacspec lib (https://github.com/hacspec/hacspec/tree/master/lib) doesn't typecheck any longer with `num-bigint` version `0.4.5`. The hacspec lib dependents on `num-bigint` version `0.4`, not specifying the minor version. The `specs` repository has no `Cargo.lock`, and thus, from a clean `git clone`, `cargo build` pins `num-bigint` to version `0.4.5`, breaking the hacspec library. Two options were considered: - remove the tests related to the specs in the CI of hax; - commit a `Cargo.lock`. The choose the first one: we need to update those specifications to hax anyway: this will add motivation to hacspec/specs#13.
W95Psp
added a commit
to hacspec/hax
that referenced
this issue
May 7, 2024
The https://github.com/hacspec/specs repository contains specifications written in hacspec, mainly at the time of hacspec v1. Since hacspec v1 is deprecated and archived, its library is deprecated as well. The hacspec lib (https://github.com/hacspec/hacspec/tree/master/lib) doesn't typecheck any longer with `num-bigint` version `0.4.5`. The hacspec lib dependents on `num-bigint` version `0.4`, not specifying the minor version. The `specs` repository has no `Cargo.lock`, and thus, from a clean `git clone`, `cargo build` pins `num-bigint` to version `0.4.5`, breaking the hacspec library. This broke #653 recently, and we had the same kind of errors a couple times before in the past. Two options were considered: - remove the tests related to the specs in the CI of hax; - commit a `Cargo.lock`. The choose the first one: we need to update those specifications to hax anyway: this will add motivation to hacspec/specs#13.
W95Psp
added a commit
to hacspec/hax
that referenced
this issue
May 7, 2024
The https://github.com/hacspec/specs repository contains specifications written in hacspec, mainly at the time of hacspec v1. Since hacspec v1 is deprecated and archived, its library is deprecated as well. The hacspec lib (https://github.com/hacspec/hacspec/tree/master/lib) doesn't typecheck any longer with `num-bigint` version `0.4.5`. The hacspec lib dependents on `num-bigint` version `0.4`, not specifying the minor version. The `specs` repository has no `Cargo.lock`, and thus, from a clean `git clone`, `cargo build` pins `num-bigint` to version `0.4.5`, breaking the hacspec library. This broke #653 recently, and we had the same kind of errors a couple times before in the past. Two options were considered: - remove the tests related to the specs in the CI of hax; - commit a `Cargo.lock`. The choose the first one: we need to update those specifications to hax anyway: this will add motivation to hacspec/specs#13.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Rewrite all specs for v2.
When rewriting a spec, please link it to this issue and file a new issue for it so everyone knows it's being worked on.
The text was updated successfully, but these errors were encountered: