Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[caprieval] with ensemble as reference #1132

Closed
VGPReys opened this issue Nov 6, 2024 · 5 comments · Fixed by #1133
Closed

[caprieval] with ensemble as reference #1132

VGPReys opened this issue Nov 6, 2024 · 5 comments · Fixed by #1133
Assignees
Labels
bug Something isn't working community Feature requests / contribution / issues from users m|caprieval Improvements in caprieval module

Comments

@VGPReys
Copy link
Contributor

VGPReys commented Nov 6, 2024

When providing an ensemble as in the parameter reference_fname, no computation is performed, as there is a bug in the alignment procedure.

Module/Workflow/Library affected

[caprieval]

Expected behavior

Actual behavior

part of the log

Running [caprieval] module
[2024-11-05 16:40:36,091 __init__ INFO] [caprieval] Found previous CNS step: 1_rigidbody
[2024-11-05 16:40:36,192 __init__ INFO] [caprieval] Saved scoring weights to: weights_params.json
[2024-11-05 16:41:17,429 libutil INFO] Selected 30 cores to process 1782 jobs, with 32 maximum available cores.
[2024-11-05 16:41:17,431 libparallel INFO] Using 30 cores
[2024-11-05 16:41:17,468 capri WARNING] Alignment failed between ../data/4_caprieval/reference.pdb and [pdb|2024-11-05 15:50:45] /hddb/roxana/protein-RNA_tutorial/7q4l_redock_bound/3_seletopclusts/3_seletopclusts/cluster_23_model_3.pdb, skipping...
[2024-11-05 16:41:17,473 capri WARNING] Alignment failed between ../data/4_caprieval/reference.pdb and [pdb|2024-11-05 15:50:46] /hddb/roxana/protein-RNA_tutorial/7q4l_redock_bound/3_seletopclusts/3_seletopclusts/cluster_38_model_3.pdb, skipping...

Steps to reproduce the behavior

[caprieval]
reference_fname = "ensemble.pdb"

Suggestions on how to fix it

  • Parse the reference_fname
  • Select first model
  • Make comparison against all models ?

Version

Additional context

Discovered by our best user: Roxana !

@VGPReys VGPReys added the bug Something isn't working label Nov 6, 2024
@VGPReys VGPReys self-assigned this Nov 6, 2024
@mgiulini mgiulini added the community Feature requests / contribution / issues from users label Nov 6, 2024
@mgiulini
Copy link
Contributor

mgiulini commented Nov 6, 2024

I would probably go with selecting the first model within the ensemble

@VGPReys
Copy link
Contributor Author

VGPReys commented Nov 6, 2024

Yes, me too, much simpler.

But there is an interesting situation where you would like to compare your result to a NMR structure represented by an ensemble of conformation, and where there is no trivial ways to assess the quality of your results.

@VGPReys
Copy link
Contributor Author

VGPReys commented Nov 6, 2024

We could create a new parameter to tackle this purpose.

@mgiulini
Copy link
Contributor

mgiulini commented Nov 6, 2024

yes, but handling that case would make things very complicated code-wise (multiple capri files to be written etc), while a much simpler solution is to run caprieval sequentially over all the elements of the ensemble.
we just have to put a warning when an ensemble is detected, maybe something along these lines:
WARNING: selecting first model out of reference ensemble: consider providing different ensemble elements as reference_fname in sequential caprieval modules

@VGPReys
Copy link
Contributor Author

VGPReys commented Dec 17, 2024

Closed by #1133

@VGPReys VGPReys closed this as completed Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community Feature requests / contribution / issues from users m|caprieval Improvements in caprieval module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants