From ff681e6d9645a13446cf8418c6248ccf1e211701 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ha=C3=AF=7E?= Date: Fri, 29 Nov 2024 11:58:25 +0100 Subject: [PATCH] (BREAKING) Apply planned breaking changes as specified in the AAC V1 release: - As specified in the changelog for the official release of Animator As Code V1, breaking changes had been planned, and will be applied starting this version: - (BREAKING) AacFlSettingKeyframes constructor is now private. - For compatibility reasons, it was public for the duration of V1.1.x, and was already marked as obsolete in V1.1.x. - (BREAKING) The methods AacFlBase.InternalConfiguration and AacFlBase.InternalDoCreateLayer are now private. - For compatibility reasons, it was public for the duration of V1.1.x, and was already marked as obsolete in V1.1.x. - The class AacAccessorForExtensions replaced them. --- .../dev.hai-vr.animator-as-code.v1/V1/Editor/Aac.cs | 12 ++++++------ .../V1/Editor/AacFlAnimations.cs | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/Packages/dev.hai-vr.animator-as-code.v1/V1/Editor/Aac.cs b/Packages/dev.hai-vr.animator-as-code.v1/V1/Editor/Aac.cs index 80549ab..c8f0b80 100644 --- a/Packages/dev.hai-vr.animator-as-code.v1/V1/Editor/Aac.cs +++ b/Packages/dev.hai-vr.animator-as-code.v1/V1/Editor/Aac.cs @@ -472,9 +472,9 @@ public class AacFlBase { private readonly AacConfiguration _configuration; - /// NOT FOR PUBLIC USE: Internal use only so that destructive workflow can access this. Maybe this can be improved - [Obsolete("This will be made private/internal in V1.2.0. Use AacAccessorForExtensions.AccessConfiguration(...) instead")] - public AacConfiguration InternalConfiguration() + /// NOT FOR PUBLIC USE: Internal use only so that destructive workflow can access this. Has been replaced with AacAccessorForExtensions.AccessConfiguration + [Obsolete("This has been made private/internal in V1.2.0. Use AacAccessorForExtensions.AccessConfiguration(...) instead")] + internal AacConfiguration InternalConfiguration() { return _configuration; } @@ -583,9 +583,9 @@ public AacFlController NewAnimatorController(string name) /// Destructive workflow: Clears the topmost layer of an arbitrary AnimatorController, and returns it. public AacFlLayer CreateFirstArbitraryControllerLayer(AnimatorController controller) => DoCreateLayer(controller, controller.layers[0].name); - /// NOT FOR PUBLIC USE: Internal use only so that destructive workflow can access this. Maybe this can be improved - [Obsolete("This will be made private/internal in V1.2.0. Use AacAccessorForExtensions.CreateLayer(...) instead")] - public AacFlLayer InternalDoCreateLayer(AnimatorController animator, string layerName) + /// NOT FOR PUBLIC USE: Internal use only so that destructive workflow can access this. Has been replaced with AacAccessorForExtensions.CreateLayer + [Obsolete("This has been made private/internal in V1.2.0. Use AacAccessorForExtensions.CreateLayer(...) instead")] + internal AacFlLayer InternalDoCreateLayer(AnimatorController animator, string layerName) { return DoCreateLayer(animator, layerName); } diff --git a/Packages/dev.hai-vr.animator-as-code.v1/V1/Editor/AacFlAnimations.cs b/Packages/dev.hai-vr.animator-as-code.v1/V1/Editor/AacFlAnimations.cs index bc5bcf4..7045af2 100644 --- a/Packages/dev.hai-vr.animator-as-code.v1/V1/Editor/AacFlAnimations.cs +++ b/Packages/dev.hai-vr.animator-as-code.v1/V1/Editor/AacFlAnimations.cs @@ -649,8 +649,8 @@ public class AacFlSettingKeyframes private readonly List _mutatedKeyframes; // Will be made private/internal in V1.2.0. - [Obsolete("This will be made private/internal in V1.2.0")] - public AacFlSettingKeyframes(AacFlUnit unit, List mutatedKeyframes) + [Obsolete("This has been made private/internal in V1.2.0")] + internal AacFlSettingKeyframes(AacFlUnit unit, List mutatedKeyframes) { _unit = unit; _mutatedKeyframes = mutatedKeyframes;