Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed issue (oninvalidateanimatorcontroller) #33

Open
Happyrobot33 opened this issue Dec 12, 2022 · 4 comments
Open

Speed issue (oninvalidateanimatorcontroller) #33

Happyrobot33 opened this issue Dec 12, 2022 · 4 comments
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@Happyrobot33
Copy link

im noticing the main reason large animators take a while to generate, is every single operation that is called seems to invoke AnimatorControllerCallback.OnInvalidateAnimatorController()

if there was a way to avoid this invoke till we are done completely editing the graph, then call it do do it all at once, I think itd singificantly speed up large graph generation. Right now im working on a project where this is 50% of the profiled time, and it is called over 21039 times

@Happyrobot33
Copy link
Author

it might be useful to use the advice from here AssetDatabase.StartAssetEditing();

suggesting a slight rewrite to store everything into a buffer, then have a function call to write it all to the animator once the creation script has finished

@Happyrobot33
Copy link
Author

seems to be highly related to having either the parameters of the animator that is being changed open in the animator window, or having a layer open that is being edited in the animator window

@hai-vr hai-vr added the documentation Improvements or additions to documentation label Sep 30, 2023
@hai-vr hai-vr added this to the V1.0.9910 milestone Sep 30, 2023
@hai-vr
Copy link
Owner

hai-vr commented Oct 1, 2023

Note to self: Documentation and examples may need to be changed to integrate AssetDatabase.StartAssetEditing()

@hai-vr
Copy link
Owner

hai-vr commented Aug 19, 2024

Note to self: Need to update documentation for barebones mode to include the use of StartAssetEditing.

Using StartAssetEditing is not necessary in non-destructive workflows as this invocation is managed by NDMF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants