Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shared link password length limit is hard coded #1458

Open
ThatLurker opened this issue May 9, 2023 · 0 comments
Open

shared link password length limit is hard coded #1458

ThatLurker opened this issue May 9, 2023 · 0 comments

Comments

@ThatLurker
Copy link

ThatLurker commented May 9, 2023

Currently, the shared link password minimum limit is hard coded in the shared link dialog. This poses a problem when the server's minimum password limit is changed to a higher number. In such cases, if a user attempts to create a shared link with a password that is lower than the server limit, no error handling is triggered, and nothing happens.

QLabel *password_label = new QLabel(tr("Password(At least 8 characters)"));

https://github.com/haiwen/seafile-client/blob/master/src/filebrowser/sharedlink-dialog.cpp#L24

The best way would be to retrieve the minimum password limit from the server dynamically if possible, so that the user knows why nothing happens when they have typed a password that is lower than the set minimum.

@ThatLurker ThatLurker changed the title shared link password limit is hard coded shared link password length limit is hard coded May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant