Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: acme.sh should be upgraded after installation #370

Closed
kirisakow opened this issue Jan 26, 2024 · 0 comments
Closed

Dockerfile: acme.sh should be upgraded after installation #370

kirisakow opened this issue Jan 26, 2024 · 0 comments

Comments

@kirisakow
Copy link

Problem

As the Seafile image evolves, I notice however that the version of acme.sh remains the same: v3.0.2 (while as of today the latest is v3.0.8). This goes against the official acme.sh documentation, which states:

acme.sh is in constant development, so it's strongly recommended to use the latest code.

Possible solution

Dockerfile should include instructions for upgrading acme.sh after installation. In other words, the command

cd /scripts/acme.sh && /scripts/acme.sh/acme.sh --install

should be

cd /scripts/acme.sh && /scripts/acme.sh/acme.sh --install \
                    && /scripts/acme.sh/acme.sh --upgrade \
                    && ln -sf /root/.acme.sh/acme.sh /scripts/acme.sh/acme.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants