Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1545 overlap fixes #1546

Merged
merged 12 commits into from
Jan 16, 2025
Merged

Feature/1545 overlap fixes #1546

merged 12 commits into from
Jan 16, 2025

Conversation

OlofSvahnVbg
Copy link
Collaborator

closes #1545

@OlofSvahnVbg OlofSvahnVbg added the new feature Request for adding/changing functionality label Sep 18, 2024
@OlofSvahnVbg OlofSvahnVbg added this to the 3.x milestone Sep 18, 2024
@OlofSvahnVbg OlofSvahnVbg self-assigned this Sep 18, 2024
@jacobwod
Copy link
Member

I'd love to start using it, but unfortunately there are some issues to be resolved. Does anyone else see the same behaviour?

Skarminspelning.2024-11-27.kl.10.24.25.mov

@Hallbergs
Copy link
Member

Hallbergs commented Dec 9, 2024

What browser are you using @jacobwod?

Tested it on Chrome, Edge, and Firefox on Windows and could not reproduce. Could it be safari related...?

@Albinahmetaj
Copy link
Contributor

Albinahmetaj commented Dec 9, 2024

I checked out the branch and read the issue description for clarification to myself. However I do not get the same "flickering" behavior as you showed in the video above @jacobwod, am I missing something? I tested the feature as it is and did not apply any extra configuration.

@jacobwod
Copy link
Member

The flickering appears to be a Safari-only issue.

Would be interesting to try it out on iOS Safari too, haven't got the opportunity though.

@OlofSvahnVbg
Copy link
Collaborator Author

So, should we accept this as is and handle the flickering issue as a separate bug?

@jesade-vbg
Copy link
Contributor

So, should we accept this as is and handle the flickering issue as a separate bug?

Sorry but no, in my opinion. Maybe if we had a working fix brewing, but we don't right now.

@Hallbergs
Copy link
Member

@jesade-vbg @OlofSvahnVbg If i remember correctly we agreed that @OlofSvahnVbg was to create a separate issue since the flickering does not seem to be related to this PR. (We have flickering when using safari in develop as well).

@OlofSvahnVbg please create a separate issue so that we can merge this PR.

@Hallbergs Hallbergs merged commit f10baf9 into develop Jan 16, 2025
@Hallbergs Hallbergs deleted the feature/1545-overlap-fixes branch January 16, 2025 13:38
@Hallbergs Hallbergs linked an issue Jan 17, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Request for adding/changing functionality
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Search: Overlap fixes
5 participants