Issue/remove setup.sh #103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the Dockerfile to use the official WordPress image and run commands that install the theme and plugins it is dependent on. It does not activate anything and does not configure plugins. modified: Dockerfile
Removed all theme installing into wordpress because this is done in the docker-compose file. Added image command to docker-compose otherwise you cannot deploy as a stack. The image is local only so needs to be built with the docker file first. modified: Dockerfile modified: docker-compose.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is intended to close #102 but I haven't actually removed the
setup.shscript yet or updated theREADME.md. The reason I left it there is because I wanted to maybe get @nzchicken or someone to review it by pulling down the branch and run it to make sure its all good.To get this version of the project up and running, run the following commands after navigating to the project root.
To stop the application
All the other instructions in the
README.mdat the moment can be done but to access the bash, the name of the node will need to be used sodocker exec -it "davehakkens_db.1.hkv2w87t17w1mbp7hyo6p77yx" bashas an example.
If you like what I've done, I'll update the
README.mdthen it could be merged in. If not, let me know what's happening and I'll try and sort it.