Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

[Android] The photo doesn't show full screen in landscape mode. #4

Open
7kfpun opened this issue May 9, 2016 · 1 comment
Open

Comments

@7kfpun
Copy link

7kfpun commented May 9, 2016

The image gallery could not show photo full screen on Android in landscape mode. However, on iOS, it works correctly.

@halilb
Copy link
Owner

halilb commented May 10, 2016

Thanks for the contribution @7kfpun.

I debugged the code and realised two problems about Dimensions in android. First, didUpdateDimensions event is not fired on android. Second, Dimensions.get('window') is always returning width/height for landscape state. There is a react-native issue about the second problem.

There are 3rd party modules to detect orientation change but they require additional installation steps, and i'm not happy with requiring one of them as a dependency here. I'm not sure how to proceed with this issue.

I'm currently re-rendering every image in full screen mode to make them full screen. Maybe there is a better way to make it right.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants