Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

还未审核通过不向文章作者发送通知邮件 #170

Open
jhqwqmc opened this issue Nov 25, 2024 · 6 comments
Open

还未审核通过不向文章作者发送通知邮件 #170

jhqwqmc opened this issue Nov 25, 2024 · 6 comments
Labels
kind/improvement Categorizes issue or PR as related to a improvement. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.

Comments

@jhqwqmc
Copy link

jhqwqmc commented Nov 25, 2024

如果文章作者没有评论管理权限那么需要等待评论审核通过才能收到被评论的通知邮件
@guqing
Copy link
Member

guqing commented Nov 27, 2024

关于你提到的这一点我并没有复现，
我的步骤：

  1. 创建一个 test 用户
  2. 分配角色，拥有作者和评论查看权限，没有评论管理权限
  3. test 用户创建一篇测试文章
  4. 匿名评论这篇文章，test 收到通知并且评论处于待审核状态

Image

/triage needs-information

@f2c-ci-robot f2c-ci-robot bot added the triage/needs-information Indicates an issue needs more information in order to work on it. label Nov 27, 2024
@jhqwqmc
Copy link
Author

jhqwqmc commented Nov 27, 2024

关于你提到的这一点我并没有复现， 我的步骤：

  1. 创建一个 test 用户
  2. 分配角色，拥有作者和评论查看权限，没有评论管理权限
  3. test 用户创建一篇测试文章
  4. 匿名评论这篇文章，test 收到通知并且评论处于待审核状态

Image

/triage needs-information

我是希望可以完善下这个功能，因为没有审核的评论不应该发给其他用户

@jhqwqmc
Copy link
Author

jhqwqmc commented Nov 27, 2024

等审核通过了再发送会更好些

@guqing
Copy link
Member

guqing commented Nov 28, 2024

发送通知的一个很重要的目的是让管理员可以审核，所以之前没有考虑只有查看没有审核权限的情况，可以考虑判断是否有评论管理权限，如果有则直接发送，否则审核通过之后在发送

/kind improvement

@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Nov 28, 2024
@guqing
Copy link
Member

guqing commented Nov 28, 2024

/remove-triage needs-information
/priority awaiting-more-evidence

@f2c-ci-robot f2c-ci-robot bot added priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. and removed triage/needs-information Indicates an issue needs more information in order to work on it. labels Nov 28, 2024
@jhqwqmc
Copy link
Author

jhqwqmc commented Nov 28, 2024

发送通知的一个很重要的目的是让管理员可以审核，所以之前没有考虑只有查看没有审核权限的情况，可以考虑判断是否有评论管理权限，如果有则直接发送，否则审核通过之后在发送

/kind improvement

是的我的意思就是这个

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/improvement Categorizes issue or PR as related to a improvement. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@guqing @jhqwqmc