Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#36] Modify .gitignore to accept example dir in tracking scope #37

Merged
merged 1 commit into from
Apr 4, 2017
Merged

[#36] Modify .gitignore to accept example dir in tracking scope #37

merged 1 commit into from
Apr 4, 2017

Conversation

Lment
Copy link
Contributor

@Lment Lment commented Apr 4, 2017 •
edited
Loading

Modify .gitignore not to ignore example directory and files in it, to use them in argument passing check.

@Lment Lment added the bug label Apr 4, 2017
@Lment Lment added this to the Project #2 milestone Apr 4, 2017
@Lment Lment self-assigned this Apr 4, 2017
@Lment Lment requested a review from hangpark April 4, 2017 16:50
hangpark
hangpark requested changes Apr 4, 2017
View reviewed changes
Copy link
Owner

@hangpark hangpark left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this include iss/4 commit? (I think you made a iss/36 branch from iss/4 branch. It should be made directly from develop.)

And your PR title and commit message MUST be changed to appropriately.

hangpark
hangpark requested changes Apr 4, 2017
View reviewed changes
.gitignore Outdated
@@ -1,9 +1,10 @@
bochs/
build/
examples/

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why empty line?

.gitignore Outdated
*.output
*.txt
*.swp
*.o
*.d
!src/tests/**/*.txt

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why empty line?

@Lment Lment changed the title [#36] Adding exception to push 'examples' directory [#36] Modify .gitignore to accept example dir in tracking scope. Apr 4, 2017
@Lment Lment changed the title [#36] Modify .gitignore to accept example dir in tracking scope. [#36] Modify .gitignore to accept example dir in tracking scope Apr 4, 2017
hangpark
hangpark approved these changes Apr 4, 2017
View reviewed changes
Copy link
Owner

@hangpark hangpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, 👍

@hangpark hangpark merged commit 9cbfdfe into develop Apr 4, 2017
@Lment Lment deleted the iss/36 branch April 4, 2017 18:42
@hangpark hangpark mentioned this pull request Apr 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangpark hangpark hangpark approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Project #2
Development

Successfully merging this pull request may close these issues.
2 participants
@Lment @hangpark