Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in function ols.RMSE #9

Open
xaviweise opened this issue Aug 5, 2020 · 1 comment
Open

Issue in function ols.RMSE #9

xaviweise opened this issue Aug 5, 2020 · 1 comment

Comments

@xaviweise
Copy link

Both in the book and in the library the ols.RMSE function is implemented using the wavg function, but this seems to me incorrect, since wavg is according to the documentation (sum x*y) % sum x, so it is dividing by sum t instead of count t. This actually makes possible to have negative values depending on the order of model 0 and 1. In my opinion a simple solution could be to use sqrt avg t * t: tabModel...
Best regards

@xaviweise
Copy link
Author

Actually, in page 260 within ols.inOut RMSE is calculated in the way I was mentioning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant