Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React 19 #226

Open
jasonsyoung opened this issue Jan 7, 2025 · 1 comment
Open

React 19 #226

jasonsyoung opened this issue Jan 7, 2025 · 1 comment

Comments

@jasonsyoung
Copy link

I couldn't find any issue referencing this, but it seems this library has a hardcoded max version of react 18. Any plans to support React 19?
@narnigrin
Copy link

For what it's worth, running the codemod recommended on https://react.dev/blog/2024/04/25/react-19-upgrade-guide shows only one change in example/index.jsx (changing render() to createRoot().render() ), so the actual component (lib/datetime-picker.jsx) seems to play fine with React 19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jasonsyoung @narnigrin