Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript types declaration file #22

Closed
geopic opened this issue Jan 30, 2020 · 4 comments
Closed

TypeScript types declaration file #22

geopic opened this issue Jan 30, 2020 · 4 comments

Comments

@geopic
Copy link

geopic commented Jan 30, 2020

This npm package needs a TypeScript types declaration file so that developers who enjoy writing with TS can use it with this package and have a better development experience. Would you like me to write one?

@mattboutet
Copy link
Member

I'm not opposed to the idea, but I don't really understand what the benefits are of shipping them with the npm package versus having community typings on definitelytyped.

I don't use typescript, so my concern is that if I start including them with the package, I'm implicitly committing to maintaining them, and I don't have the knowledge or desire to do that.

@geopic
Copy link
Author

geopic commented Jan 30, 2020

I don't use typescript, so my concern is that if I start including them with the package, I'm implicitly committing to maintaining them, and I don't have the knowledge or desire to do that.

That's fine, you make a valid point. I'll close this issue and a contributor can add types via the definitelytyped route.

@geopic geopic closed this as completed Jan 30, 2020
@devinivy
Copy link
Member

Just wanted to add: there is an ongoing conversation about how we might address typescript support in the #hapipal channel of the hapi hour slack.

We are looking for creative solutions where hapi pal as an organization can facilitate the creation and maintenance of typings as a community effort.

@devinivy
Copy link
Member

Here is an issue for further discussion: hapipal/discuss#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants