BUG/MEDIUM: cluster: do not ignore error

oktalz · mjuraga · commit 7c9cc841c39b · 2022-04-01T09:49:34.000+02:00
If an error occurs, the runtime may not be used and hence we must exit.
diff --git a/configuration/cluster_sync_helpers.go b/configuration/cluster_sync_helpers.go
@@ -32,6 +32,7 @@ func (c *ClusterSync) getNodeFacts() map[string]string {
 	runtime, err := c.cli.Runtime()
 	if err != nil {
 		log.Errorf("unable to fetch processInfo: %s", err.Error())
+		return facts
 	}
 	processInfos, err := runtime.GetInfo()
 	if err != nil || len(processInfos) < 1 {

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,7 @@ func (c *ClusterSync) getNodeFacts() map[string]string {`
`32`	`32`	`runtime, err := c.cli.Runtime()`
`33`	`33`	`if err != nil {`
`34`	`34`	`log.Errorf("unable to fetch processInfo: %s", err.Error())`
	`35`	`+ return facts`
`35`	`36`	`}`
`36`	`37`	`processInfos, err := runtime.GetInfo()`
`37`	`38`	`if err != nil \|\| len(processInfos) < 1 {`