Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vault replace feature #95

Open
gupadhyaya opened this issue Mar 31, 2022 · 1 comment
Open

vault replace feature #95

gupadhyaya opened this issue Mar 31, 2022 · 1 comment
Assignees
@hashmesan

Comments

@gupadhyaya
Copy link
Contributor

currently vault replace feature is disabled due to bugs and needs fixing.
@hashmesan
Copy link

Can you clarify what challenges you had with it so i can approach it better?

hashmesan pushed a commit to hashmesan/onebtc that referenced this issue Apr 28, 2022
harmony-one#95 simplify requestIssue, allow only valid btcAmount request
7453d4b 
* Implicitly setting btcAmount below eligible amount makes difficult to calculate griefing amount and making the code significant more complex than necessary.
* Test case_requestReplace  passed
hashmesan pushed a commit to hashmesan/onebtc that referenced this issue Apr 28, 2022
harmony-one#95 fixed executeRedeem interface , all tests passed
94667c2 
    ✓ Register OLD Vault with 10 Wei Collateral (94ms)
    ✓ Issue 0.5 OneBtc (836ms)
    ✓ Request Replace (116ms)
    ✓ Register NEW Vault with 10 Wei Collateral (78ms)
    ✓ Accept Replace (602ms)
    ✓ Execute Replace (95ms)
hashmesan pushed a commit to hashmesan/onebtc that referenced this issue Apr 28, 2022
harmony-one#95 added cancelReplace, test case, snapshot, revert
e49ffa7 
* ensure we request above dust amount (non-zero)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hashmesan hashmesan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gupadhyaya @hashmesan