diff --git a/.github/workflows/pull_request_template.md b/.github/workflows/pull_request_template.md new file mode 100644 index 0000000..2dd75fc --- /dev/null +++ b/.github/workflows/pull_request_template.md @@ -0,0 +1,23 @@ +## Related Tasks + +Does this PR relate to other tasks? + +## Depends on + +Are there any other PRs that need to be merged first? + +## What + +What changes have been made within this PR? + +## Why + +Why are we submitting this PR? What is the context, engineering and business goals being satisfied by this PR? + +## Concerns + +This section is optional, however if you have any concerns or questions regarding aspects of the PR, they can be included here. Including the concerns in this section ensures that they can be discussed as a part of the PR review. + +## Notes + +This section is also optional and should include anything else that you would like to discuss in the PR review that is not captured elsewhere. diff --git a/Dockerfile b/Dockerfile index faa95d3..ee43198 100644 --- a/Dockerfile +++ b/Dockerfile @@ -35,7 +35,7 @@ RUN apt-get clean \ && rm -rf /var/lib/apt/lists/* # Docker daemon entrypoint -ADD ./dockerd-entrypoint.sh /usr/local/bin +ADD ./entrypoint.sh /usr/local/bin # Prepare rootless user RUN set -ex \ @@ -47,5 +47,5 @@ RUN set -ex \ VOLUME /home/rootless/.local/share/docker EXPOSE 2375 -ENTRYPOINT ["/usr/local/bin/dockerd-entrypoint.sh"] +ENTRYPOINT ["/usr/local/bin/entrypoint.sh"] CMD [] diff --git a/Makefile b/Makefile index 61848fc..18912ee 100644 --- a/Makefile +++ b/Makefile @@ -1,6 +1,6 @@ .DEFAULT_GOAL := help -IMAGE_NAME := cobalt-rootless-nvidia-dind +IMAGE_NAME := harrisonai/cobalt-rootless-nvidia-dind ## build: build the docker image build: diff --git a/README.md b/README.md index b8e9b54..df0ba42 100644 --- a/README.md +++ b/README.md @@ -30,7 +30,7 @@ The image is based on the `debian:bullseye-slim` and incorperates these major co Launching from the CLI: ```bash -docker run --rm -it --cap-add "SYS_ADMIN" cobalt-rootless-nvidia-dind:latest +docker run --rm -it --cap-add "SYS_ADMIN" harrisonai/cobalt-rootless-nvidia-dind ``` As a Kubernetes deployment: @@ -51,8 +51,8 @@ spec: app: dind spec: containers: - - name: docker - image: cobalt-rootless-nvidia-dind:latest + - name: dind + image: harrisonai/cobalt-rootless-nvidia-dind:latest imagePullPolicy: Always resources: requests: diff --git a/dockerd-entrypoint.sh b/entrypoint.sh similarity index 100% rename from dockerd-entrypoint.sh rename to entrypoint.sh