Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison Error in src/Liquid/LocalFileSystem.php #52

Open
jonkas2211 opened this issue Dec 31, 2017 · 1 comment
Open

Comparison Error in src/Liquid/LocalFileSystem.php #52

jonkas2211 opened this issue Dec 31, 2017 · 1 comment

Comments

@jonkas2211
Copy link

Hello guys,

there are comparison errors in the file src/Liquid/LocalFileSystem.php.
There are some comparisons like: if (!$rootRegex->match(realpath($fullPath)))
wich wont be true ever, because the function match() will never return a boolean.
It just returns 0 or 1... I know a bit stupid..

@sanmai
Copy link
Contributor

sanmai commented Jan 30, 2019

In PHP-speak 0 or 1 is same as false or true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants