From 908d96fcab6e4ea085996bb32b3b1714fd2a180f Mon Sep 17 00:00:00 2001
From: Francesco Torchia <francesco.torchia@suse.com>
Date: Tue, 5 Nov 2024 12:24:16 +0100
Subject: [PATCH 1/5] Add longhorn support message in VM clone dialog

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
(cherry picked from commit d4c845206051f63389f20c847952e187758afd38)
---
 pkg/harvester/dialog/CloneVmDialog.vue        | 26 ++++++++++++-------
 pkg/harvester/l10n/en-us.yaml                 |  2 ++
 .../models/kubevirt.io.virtualmachine.js      |  9 ++-----
 3 files changed, 21 insertions(+), 16 deletions(-)

diff --git a/pkg/harvester/dialog/CloneVmDialog.vue b/pkg/harvester/dialog/CloneVmDialog.vue
index a93de39dc20..6930319f241 100644
--- a/pkg/harvester/dialog/CloneVmDialog.vue
+++ b/pkg/harvester/dialog/CloneVmDialog.vue
@@ -91,15 +91,22 @@ export default {
     </template>
 
     <template #body>
-      <Checkbox v-model="cloneData" class="mb-10" label-key="harvester.modal.cloneVM.type" />
-
-      <LabeledInput
-        v-show="cloneData"
-        v-model="name"
-        class="mb-20"
-        :label="t('harvester.modal.cloneVM.name')"
-        required
-      />
+      <template v-if="!actionResource?.longhornV2Volumes.length">
+        <Checkbox v-model="cloneData" class="mb-10" label-key="harvester.modal.cloneVM.type" />
+
+        <LabeledInput
+          v-show="cloneData"
+          v-model="name"
+          class="mb-20"
+          :label="t('harvester.modal.cloneVM.name')"
+          required
+        />
+      </template>
+      <template v-else>
+        <Banner color="warning">
+          <t k="harvester.modal.cloneVM.message.support.longhorn" :raw="true" />
+        </Banner>
+      </template>
     </template>
 
     <div slot="actions" class="actions">
@@ -109,6 +116,7 @@ export default {
         </button>
 
         <AsyncButton
+          v-if="!actionResource?.longhornV2Volumes.length"
           mode="create"
           :action-label="cloneData ? t('harvester.modal.cloneVM.action.create') : t('harvester.modal.cloneVM.action.clone')"
           :disabled="cloneData && !name"
diff --git a/pkg/harvester/l10n/en-us.yaml b/pkg/harvester/l10n/en-us.yaml
index 4beb2d5dc4d..db55bb05f2d 100644
--- a/pkg/harvester/l10n/en-us.yaml
+++ b/pkg/harvester/l10n/en-us.yaml
@@ -74,6 +74,8 @@ harvester:
         tip: Please enter a virtual machine name!
         success: 'Virtual machine { name } cloned successfully.'
         failed: 'Failed clone virtual machine!'
+        support:
+          longhorn: The VM uses Longhorn v2 volumes, which do not <a href="https://docs.harvesterhci.io/v1.4/advanced/longhorn-v2/#limitations" target="_blank">support</a> the clone action.
     exportImage:
       title: Export to Image
       name: Name
diff --git a/pkg/harvester/models/kubevirt.io.virtualmachine.js b/pkg/harvester/models/kubevirt.io.virtualmachine.js
index ee01a8816d4..616d134d8b3 100644
--- a/pkg/harvester/models/kubevirt.io.virtualmachine.js
+++ b/pkg/harvester/models/kubevirt.io.virtualmachine.js
@@ -91,16 +91,11 @@ export default class VirtVm extends HarvesterResource {
   get availableActions() {
     let out = super._availableActions;
 
-    // VM attached with Longhorn V2 volume doesn't support clone feature
-    if (this.longhornV2Volumes.length > 0) {
-      out = out.filter(action => action.action !== 'goToClone');
-    } else {
-      const clone = out.find(action => action.action === 'goToClone');
+          const clone = out.find(action => action.action === 'goToClone');
 
       if (clone) {
         clone.action = 'goToCloneVM';
-      }
-    }
+          }
 
     return [
       {

From ceb33f16e2b51931fbfa41cf1430dfd93e96d651 Mon Sep 17 00:00:00 2001
From: Francesco Torchia <francesco.torchia@suse.com>
Date: Thu, 14 Nov 2024 16:11:57 +0100
Subject: [PATCH 2/5] Add longhorn support message in Volumes
 Export,Snapshot,Clone dialogs

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
(cherry picked from commit 0b09c4bf3e66032bbcb7ad800551f2715346db43)
---
 .../dialog/HarvesterExportImageDialog.vue     | 50 +++++++++++--------
 pkg/harvester/dialog/SnapshotDialog.vue       |  6 ++-
 pkg/harvester/dialog/VolumeCloneDialog.vue    | 24 ++++++---
 pkg/harvester/l10n/en-us.yaml                 |  7 +++
 .../models/harvester/persistentvolumeclaim.js | 21 ++------
 5 files changed, 62 insertions(+), 46 deletions(-)

diff --git a/pkg/harvester/dialog/HarvesterExportImageDialog.vue b/pkg/harvester/dialog/HarvesterExportImageDialog.vue
index 1e4a3797fcc..e48e779cb70 100644
--- a/pkg/harvester/dialog/HarvesterExportImageDialog.vue
+++ b/pkg/harvester/dialog/HarvesterExportImageDialog.vue
@@ -141,27 +141,34 @@ export default {
     </template>
 
     <template #body>
-      <LabeledSelect
-        v-model="namespace"
-        :label="t('harvester.modal.exportImage.namespace')"
-        :options="namespaces"
-        class="mb-20"
-        required
-      />
-
-      <LabeledInput
-        v-model="name"
-        :label="t('harvester.modal.exportImage.name')"
-        required
-      />
-
-      <LabeledSelect
-        v-model="storageClassName"
-        :options="storageClassOptions"
-        :label="t('harvester.storage.storageClass.label')"
-        class="mt-20"
-        required
-      />
+      <template v-if="actionResource?.isLonghornV2">
+        <Banner color="warning">
+          <t k="harvester.modal.exportImage.message.support.longhorn" :raw="true" />
+        </Banner>
+      </template>
+      <template v-else>
+        <LabeledSelect
+          v-model="namespace"
+          :label="t('harvester.modal.exportImage.namespace')"
+          :options="namespaces"
+          class="mb-20"
+          required
+        />
+
+        <LabeledInput
+          v-model="name"
+          :label="t('harvester.modal.exportImage.name')"
+          required
+        />
+
+        <LabeledSelect
+          v-model="storageClassName"
+          :options="storageClassOptions"
+          :label="t('harvester.storage.storageClass.label')"
+          class="mt-20"
+          required
+        />
+      </template>
     </template>
 
     <div slot="actions" class="actions">
@@ -171,6 +178,7 @@ export default {
         </button>
 
         <AsyncButton
+          v-if="!actionResource?.isLonghornV2"
           mode="create"
           :disabled="disableSave"
           @click="save"
diff --git a/pkg/harvester/dialog/SnapshotDialog.vue b/pkg/harvester/dialog/SnapshotDialog.vue
index 1a6a423c24f..beafb3ea9ab 100644
--- a/pkg/harvester/dialog/SnapshotDialog.vue
+++ b/pkg/harvester/dialog/SnapshotDialog.vue
@@ -70,7 +70,10 @@ export default {
       {{ t('harvester.modal.snapshot.title') }}
     </template>
     <template #body>
-      <LabeledInput
+      <Banner v-if="actionResource?.isLonghornV2" color="warning">
+        <t k="harvester.modal.snapshot.message.support.longhorn" :raw="true" />
+      </Banner>
+      <LabeledInput v-else
         v-model="name"
         :label="t('harvester.modal.snapshot.name')"
         required
@@ -82,6 +85,7 @@ export default {
           {{ t('generic.cancel') }}
         </button>
         <AsyncButton
+          v-if="!actionResource?.isLonghornV2"
           mode="create"
           :disabled="disableSave"
           @click="save"
diff --git a/pkg/harvester/dialog/VolumeCloneDialog.vue b/pkg/harvester/dialog/VolumeCloneDialog.vue
index 83234c79e4c..db9f18273fb 100644
--- a/pkg/harvester/dialog/VolumeCloneDialog.vue
+++ b/pkg/harvester/dialog/VolumeCloneDialog.vue
@@ -81,15 +81,22 @@ export default {
       {{ t('harvester.modal.volumeClone.title') }}
     </template>
     <template #body>
-      <Checkbox v-model="cloneData" class="mb-10" label-key="harvester.modal.cloneVM.type" />
+      <template v-if="!actionResource?.isLonghornV2">
+        <Checkbox v-model="cloneData" class="mb-10" label-key="harvester.modal.cloneVM.type" />
 
-      <LabeledInput
-        v-show="cloneData"
-        v-model="name"
-        class="mb-20"
-        :label="t('harvester.modal.volumeClone.name')"
-        required
-      />
+        <LabeledInput
+          v-show="cloneData"
+          v-model="name"
+          class="mb-20"
+          :label="t('harvester.modal.volumeClone.name')"
+          required
+        />
+      </template>
+      <template v-else>
+        <Banner color="warning">
+          <t k="harvester.modal.volumeClone.message.support.longhorn" :raw="true" />
+        </Banner>
+      </template>
     </template>
     <div slot="actions" class="actions">
       <div class="buttons">
@@ -97,6 +104,7 @@ export default {
           {{ t('generic.cancel') }}
         </button>
         <AsyncButton
+          v-if="!actionResource?.isLonghornV2"
           mode="create"
           :disabled="disableSave"
           @click="save"
diff --git a/pkg/harvester/l10n/en-us.yaml b/pkg/harvester/l10n/en-us.yaml
index db55bb05f2d..58415a91341 100644
--- a/pkg/harvester/l10n/en-us.yaml
+++ b/pkg/harvester/l10n/en-us.yaml
@@ -82,6 +82,8 @@ harvester:
       namespace: Namespace
       message:
         success: 'Image { name } created successfully.'
+        support:
+          longhorn: The volume uses Longhorn V2 engine, which does not <a href="https://docs.harvesterhci.io/v1.4/advanced/longhorn-v2/#limitations" target="_blank">support</a> the Export Image action.
     migration:
       failedMessage: Latest migration failed!
       title: Migration
@@ -110,11 +112,16 @@ harvester:
       name: Name
       message:
         success: 'Take Snapshot { name } successfully.'
+        support:
+          longhorn: The volume uses Longhorn V2 engine, which does not <a href="https://docs.harvesterhci.io/v1.4/advanced/longhorn-v2/#limitations" target="_blank">support</a> the Take Snapshot action.
+  
     volumeClone:
       title: Clone Volume
       name: Name
       message:
         success: 'New Volume { name } cloned successfully.'
+        support:
+          longhorn: The volume uses Longhorn V2 engine, which does not <a href="https://docs.harvesterhci.io/v1.4/advanced/longhorn-v2/#limitations" target="_blank">support</a> the clone action.
     restoreSnapshot:
       title: Restore Snapshot
       name: 'New Volume Name'
diff --git a/pkg/harvester/models/harvester/persistentvolumeclaim.js b/pkg/harvester/models/harvester/persistentvolumeclaim.js
index 4596031d348..9b580417a3d 100644
--- a/pkg/harvester/models/harvester/persistentvolumeclaim.js
+++ b/pkg/harvester/models/harvester/persistentvolumeclaim.js
@@ -37,19 +37,13 @@ export default class HciPv extends HarvesterResource {
   get availableActions() {
     let out = super._availableActions;
 
-    // Longhorn V2 provisioner do not support volume clone feature yet
-    if (this.isLonghornV2) {
-      out = out.filter(action => action.action !== 'goToClone');
-    } else {
-      const clone = out.find(action => action.action === 'goToClone');
+    const clone = out.find(action => action.action === 'goToClone');
 
-      if (clone) {
-        clone.action = 'goToCloneVolume';
-      }
+    if (clone) {
+      clone.action = 'goToCloneVolume';
     }
 
-    if (!this.isLonghorn || !this.isLonghornV2) {
-      out = [
+    return [
         {
           action:  'exportImage',
           enabled: this.hasAction('export') && !this.isEncrypted,
@@ -62,12 +56,7 @@ export default class HciPv extends HarvesterResource {
           icon:    'icon icon-backup',
           label:   this.t('harvester.action.snapshot'),
         },
-        ...out
-      ];
-    }
-
-    return [
-      {
+              {
         action:  'cancelExpand',
         enabled: this.hasAction('cancelExpand'),
         icon:    'icon icon-backup',

From 499e126184c8d65c200e9d077c9e887cca4ae569 Mon Sep 17 00:00:00 2001
From: Francesco Torchia <francesco.torchia@suse.com>
Date: Thu, 14 Nov 2024 16:27:58 +0100
Subject: [PATCH 3/5] Add longhorn support message in VMs Take Snapshot dialogs

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
(cherry picked from commit fbc501dac94c90d2fc0420a94cd68497249a889b)
---
 .../dialog/HarvesterVMSnapshotDialog.vue      | 29 ++++++++++++++++---
 pkg/harvester/l10n/en-us.yaml                 |  8 +++--
 .../models/kubevirt.io.virtualmachine.js      | 10 +++----
 3 files changed, 35 insertions(+), 12 deletions(-)

diff --git a/pkg/harvester/dialog/HarvesterVMSnapshotDialog.vue b/pkg/harvester/dialog/HarvesterVMSnapshotDialog.vue
index f027c6c2294..b6e3d9bf473 100644
--- a/pkg/harvester/dialog/HarvesterVMSnapshotDialog.vue
+++ b/pkg/harvester/dialog/HarvesterVMSnapshotDialog.vue
@@ -74,7 +74,7 @@ export default {
             'growl/success',
             {
               title:   this.t('generic.notification.title.succeed'),
-              message: this.t('harvester.modal.vmSnapshot.success', { name: this.snapshotName })
+              message: this.t('harvester.modal.vmSnapshot.message.success', { name: this.snapshotName })
             },
             { root: true }
           );
@@ -118,8 +118,24 @@ export default {
     />
 
     <template #body>
-      <LabeledInput v-model="actionResource.metadata.namespace" :disabled="true" :label="t('generic.namespace')" />
-      <LabeledInput v-model="snapshotName" class="mt-20" :label="t('generic.name')" required />
+      <template v-if="actionResource?.longhornV2Volumes.length > 0">
+        <Banner color="warning">
+          <t k="harvester.modal.vmSnapshot.message.support.longhorn" :raw="true" />
+        </Banner>
+      </template>
+      <template v-else>
+        <LabeledInput
+          v-model="actionResource.metadata.namespace"
+          :disabled="true"
+          :label="t('generic.namespace')"
+        />
+        <LabeledInput
+          v-model="snapshotName"
+          class="mt-20"
+          :label="t('generic.name')"
+          required
+        />
+      </template>
     </template>
 
     <div slot="actions" class="actions">
@@ -128,7 +144,12 @@ export default {
           {{ t('generic.cancel') }}
         </button>
 
-        <AsyncButton mode="create" :disabled="!snapshotName" @click="save" />
+        <AsyncButton
+          v-if="!actionResource?.longhornV2Volumes.length"
+          mode="create"
+          :disabled="!snapshotName"
+          @click="save"
+        />
       </div>
 
       <Banner v-for="(err, i) in errors" :key="i" color="error" :label="err" />
diff --git a/pkg/harvester/l10n/en-us.yaml b/pkg/harvester/l10n/en-us.yaml
index 58415a91341..3d12125aa13 100644
--- a/pkg/harvester/l10n/en-us.yaml
+++ b/pkg/harvester/l10n/en-us.yaml
@@ -114,14 +114,13 @@ harvester:
         success: 'Take Snapshot { name } successfully.'
         support:
           longhorn: The volume uses Longhorn V2 engine, which does not <a href="https://docs.harvesterhci.io/v1.4/advanced/longhorn-v2/#limitations" target="_blank">support</a> the Take Snapshot action.
-  
     volumeClone:
       title: Clone Volume
       name: Name
       message:
         success: 'New Volume { name } cloned successfully.'
         support:
-          longhorn: The volume uses Longhorn V2 engine, which does not <a href="https://docs.harvesterhci.io/v1.4/advanced/longhorn-v2/#limitations" target="_blank">support</a> the clone action.
+          longhorn: The volume uses Longhorn V2 engine, which does not <a href="https://docs.harvesterhci.io/v1.4/advanced/longhorn-v2/#limitations" target="_blank">support</a> the Clone action.
     restoreSnapshot:
       title: Restore Snapshot
       name: 'New Volume Name'
@@ -129,7 +128,10 @@ harvester:
     vmSnapshot:
       title: Take Virtual Machine Snapshot
       name: Name
-      success: 'Take virtual machine Snapshot { name } successfully.'
+      message:
+        success: 'Take virtual machine Snapshot { name } successfully.'
+        support:
+          longhorn: The VM uses Longhorn v2 volumes, which do not <a href="https://docs.harvesterhci.io/v1.4/advanced/longhorn-v2/#limitations" target="_blank">support</a> the Take Snapshot action.
     restart:
       title: Restart Virtual Machine
       tip: Restart the virtual machine for configuration changes to take effect.
diff --git a/pkg/harvester/models/kubevirt.io.virtualmachine.js b/pkg/harvester/models/kubevirt.io.virtualmachine.js
index 616d134d8b3..13fd3454e5a 100644
--- a/pkg/harvester/models/kubevirt.io.virtualmachine.js
+++ b/pkg/harvester/models/kubevirt.io.virtualmachine.js
@@ -91,11 +91,11 @@ export default class VirtVm extends HarvesterResource {
   get availableActions() {
     let out = super._availableActions;
 
-          const clone = out.find(action => action.action === 'goToClone');
+    const clone = out.find(action => action.action === 'goToClone');
 
-      if (clone) {
-        clone.action = 'goToCloneVM';
-          }
+    if (clone) {
+      clone.action = 'goToCloneVM';
+    }
 
     return [
       {
@@ -152,7 +152,7 @@ export default class VirtVm extends HarvesterResource {
       },
       {
         action:  'takeVMSnapshot',
-        enabled: !!this.actions?.backup && !this.longhornV2Volumes.length,
+        enabled: !!this.actions?.backup,
         icon:    'icon icon-snapshot',
         label:   this.t('harvester.action.vmSnapshot')
       },

From 8b13467df7160ec07591a5492c1b146ffd5db444 Mon Sep 17 00:00:00 2001
From: Francesco Torchia <francesco.torchia@suse.com>
Date: Thu, 14 Nov 2024 16:41:51 +0100
Subject: [PATCH 4/5] Lint

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
(cherry picked from commit 70aee48ff26417f018ba2230a90bc266ceb93eed)
---
 pkg/harvester/dialog/SnapshotDialog.vue       |  3 +-
 .../models/harvester/persistentvolumeclaim.js | 28 +++++++++----------
 .../models/kubevirt.io.virtualmachine.js      |  2 +-
 3 files changed, 17 insertions(+), 16 deletions(-)

diff --git a/pkg/harvester/dialog/SnapshotDialog.vue b/pkg/harvester/dialog/SnapshotDialog.vue
index beafb3ea9ab..6cdcd42ef9c 100644
--- a/pkg/harvester/dialog/SnapshotDialog.vue
+++ b/pkg/harvester/dialog/SnapshotDialog.vue
@@ -73,7 +73,8 @@ export default {
       <Banner v-if="actionResource?.isLonghornV2" color="warning">
         <t k="harvester.modal.snapshot.message.support.longhorn" :raw="true" />
       </Banner>
-      <LabeledInput v-else
+      <LabeledInput
+        v-else
         v-model="name"
         :label="t('harvester.modal.snapshot.name')"
         required
diff --git a/pkg/harvester/models/harvester/persistentvolumeclaim.js b/pkg/harvester/models/harvester/persistentvolumeclaim.js
index 9b580417a3d..501032bb876 100644
--- a/pkg/harvester/models/harvester/persistentvolumeclaim.js
+++ b/pkg/harvester/models/harvester/persistentvolumeclaim.js
@@ -35,7 +35,7 @@ export default class HciPv extends HarvesterResource {
   }
 
   get availableActions() {
-    let out = super._availableActions;
+    const out = super._availableActions;
 
     const clone = out.find(action => action.action === 'goToClone');
 
@@ -44,19 +44,19 @@ export default class HciPv extends HarvesterResource {
     }
 
     return [
-        {
-          action:  'exportImage',
-          enabled: this.hasAction('export') && !this.isEncrypted,
-          icon:    'icon icon-copy',
-          label:   this.t('harvester.action.exportImage')
-        },
-        {
-          action:  'snapshot',
-          enabled: this.hasAction('snapshot'),
-          icon:    'icon icon-backup',
-          label:   this.t('harvester.action.snapshot'),
-        },
-              {
+      {
+        action:  'exportImage',
+        enabled: this.hasAction('export') && !this.isEncrypted,
+        icon:    'icon icon-copy',
+        label:   this.t('harvester.action.exportImage')
+      },
+      {
+        action:  'snapshot',
+        enabled: this.hasAction('snapshot'),
+        icon:    'icon icon-backup',
+        label:   this.t('harvester.action.snapshot'),
+      },
+      {
         action:  'cancelExpand',
         enabled: this.hasAction('cancelExpand'),
         icon:    'icon icon-backup',
diff --git a/pkg/harvester/models/kubevirt.io.virtualmachine.js b/pkg/harvester/models/kubevirt.io.virtualmachine.js
index 13fd3454e5a..5c6386b9391 100644
--- a/pkg/harvester/models/kubevirt.io.virtualmachine.js
+++ b/pkg/harvester/models/kubevirt.io.virtualmachine.js
@@ -89,7 +89,7 @@ const IgnoreMessages = ['pod has unbound immediate PersistentVolumeClaims'];
 
 export default class VirtVm extends HarvesterResource {
   get availableActions() {
-    let out = super._availableActions;
+    const out = super._availableActions;
 
     const clone = out.find(action => action.action === 'goToClone');
 

From e0547025fbc5ef2bfc672a7827213811074e52af Mon Sep 17 00:00:00 2001
From: Francesco Torchia <francesco.torchia@suse.com>
Date: Fri, 15 Nov 2024 09:50:59 +0100
Subject: [PATCH 5/5] Update pkg/harvester/l10n/en-us.yaml

Co-authored-by: Andy Lee <andy.lee@suse.com>
(cherry picked from commit 1f1d421a6a0ae71279d79c21123c7e2fde6a44fb)
---
 pkg/harvester/l10n/en-us.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pkg/harvester/l10n/en-us.yaml b/pkg/harvester/l10n/en-us.yaml
index 3d12125aa13..4cb9e6bbdd2 100644
--- a/pkg/harvester/l10n/en-us.yaml
+++ b/pkg/harvester/l10n/en-us.yaml
@@ -75,7 +75,7 @@ harvester:
         success: 'Virtual machine { name } cloned successfully.'
         failed: 'Failed clone virtual machine!'
         support:
-          longhorn: The VM uses Longhorn v2 volumes, which do not <a href="https://docs.harvesterhci.io/v1.4/advanced/longhorn-v2/#limitations" target="_blank">support</a> the clone action.
+          longhorn: The virtual machine uses Longhorn v2 volumes, which do not <a href="https://docs.harvesterhci.io/v1.4/advanced/longhorn-v2/#limitations" target="_blank">support</a> the Clone action.
     exportImage:
       title: Export to Image
       name: Name