Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The cards for choosing a place for the business #8

Open
mohammad-suliman opened this issue Jan 15, 2023 · 0 comments
Open

The cards for choosing a place for the business #8

mohammad-suliman opened this issue Jan 15, 2023 · 0 comments

Comments

@mohammad-suliman
Copy link

Problem description:

When reaching the question which asks about whether you want to hear about the different areas in the town where you can have your business in, a map with a set of cards corresponding to the different regions is displayed.
The map and the cards view have the following accessibility issues:

  • The map and the cards is not linked in a meaningful way. Maybe considering defining the map in figure and the cards as a figcaption is a good idea?
  • Each card title is defined as h1 - which is semantically not correct I guess, thus a confusing experience for a screen reader user
  • The button for choosing a specific card in each card lacks semantic and keyboard interaction:
    • It has no role to be identified by assistive technologies
    • Not reachable by the keyboard
    • Has no focus visible effect so a sighted keyboard user can tell whether it has focus

Solution:

  • somehow link the map to the cards it includes
  • Fix the heading level hierarchy issue
  • Fix the button for choosing a card by:
    • Add a role using the role attribute
    • Add tabindex = 0 to have it in the tab order
    • Add styling in CSS for focus outline when the button gets focus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant