Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove surl dependency #150

Open
acuarica opened this issue Dec 11, 2024 · 0 comments
Open

Remove surl dependency #150

acuarica opened this issue Dec 11, 2024 · 0 comments
Labels
dependencies Add, update or remove dependency packages or files

Comments

@acuarica
Copy link
Contributor

To keep the submodule dependencies lean and less bloated, we should remove surl dependency. By having this library the user is cloning the following repos

Submodule 'lib/surl' (https://github.com/memester-xyz/surl) registered for path 'lib/surl'
Submodule 'lib/forge-std' (https://github.com/foundry-rs/forge-std) registered for path 'lib/surl/lib/forge-std'
Submodule 'lib/solidity-stringutils' (https://github.com/Arachnid/solidity-stringutils) registered for path 'lib/surl/lib/solidity-stringutils'
Submodule 'lib/ds-test' (https://github.com/dapphub/ds-test) registered for path 'lib/surl/lib/forge-std/lib/ds-test'
Submodule 'lib/ds-test' (https://github.com/dapphub/ds-test) registered for path 'lib/surl/lib/solidity-stringutils/lib/ds-test'

(it includes an old version of Foundry v1.3.0 that includes ds-test as well).

@acuarica acuarica added build Improve build, bundling or deployment process dependencies Add, update or remove dependency packages or files and removed build Improve build, bundling or deployment process labels Dec 11, 2024
@arianejasuwienas arianejasuwienas self-assigned this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Add, update or remove dependency packages or files
Projects
Status: Backlog
Development

No branches or pull requests

2 participants