Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ledgerId when forking from Local Node #163

Open
acuarica opened this issue Dec 21, 2024 · 0 comments
Open

Fix ledgerId when forking from Local Node #163

acuarica opened this issue Dec 21, 2024 · 0 comments
Labels
feature Enhancing an existing feature driven by business requirements. Typically backwards compatible.

Comments

@acuarica
Copy link
Contributor

The ledgerId does not return the proper value when forking from a local node network. This applies to both Foundry library and Hardhat plugin.

For the Foundry library, the solution is simpler because the chainId is already available. We just need to include another case for local node in HtsSystemContractJson::_getLedgerId.

On the other hand, for the Hardhat plugin, the core function getHtsStorageAt does not have JSON-RPC access. We could however extend the IMirrorNodeClient to support retrieving the chainId of the remote network.

@acuarica acuarica added the feature Enhancing an existing feature driven by business requirements. Typically backwards compatible. label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Enhancing an existing feature driven by business requirements. Typically backwards compatible.
Projects
Status: Backlog
Development

No branches or pull requests

1 participant