Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include HtsSystemContract.json in version control #165

Closed
acuarica opened this issue Dec 21, 2024 · 0 comments · Fixed by #169
Closed

Include HtsSystemContract.json in version control #165

acuarica opened this issue Dec 21, 2024 · 0 comments · Fixed by #169
Assignees
Labels
build Improve build, bundling or deployment process

Comments

@acuarica
Copy link
Contributor

acuarica commented Dec 21, 2024

Most of the issues included in the #146 epic, use HTS forking from Hardhat. However, currently Hardhat users are unable to use our solution until we publish the package to npm #54. But at the same time, it would be good to have user validation before publishing.

At the start of this project, we try to solve this issue by including HtsSystemContract.json in the repo so that Hardhat users can consume the plugin directly from GitHub.

We removed it #122 when we had multiple npm packages.

Given that after #139 we have a single npm package again, we can re-include the .json output so that Hardhat users can consume the repo without the package being published yet.

Once we have a strong validation from users, we can publish to npm as originally planned.

@acuarica acuarica added the build Improve build, bundling or deployment process label Dec 21, 2024
@acuarica acuarica self-assigned this Jan 2, 2025
@acuarica acuarica moved this from Backlog to Tasks In Progress in Smart Contract Sprint Board Jan 2, 2025
@acuarica acuarica linked a pull request Jan 3, 2025 that will close this issue
2 tasks
@acuarica acuarica moved this from Tasks In Progress to In Review in Smart Contract Sprint Board Jan 3, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in Smart Contract Sprint Board Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Improve build, bundling or deployment process
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant