Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert getHtsStorageAt into a method to support persistent state #178

Open
acuarica opened this issue Jan 9, 2025 · 0 comments
Open

Convert getHtsStorageAt into a method to support persistent state #178

acuarica opened this issue Jan 9, 2025 · 0 comments
Labels
feature Enhancing an existing feature driven by business requirements. Typically backwards compatible.

Comments

@acuarica
Copy link
Contributor

acuarica commented Jan 9, 2025

PR #173 introduces a stateful mechanism to deal with tokenURI occupying more than one slot. This state is global, which lacks flexibility and could cause issues and confusion (given the state is not explicit) for consumers of the package.

To solve this problem, we should convert the getHtsStorageAt function into a class method and move the persistent state into the new class. This way, the state is now explicit, avoiding any surprise to the user.

@acuarica acuarica added the feature Enhancing an existing feature driven by business requirements. Typically backwards compatible. label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Enhancing an existing feature driven by business requirements. Typically backwards compatible.
Projects
Status: Backlog
Development

No branches or pull requests

1 participant