Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP-1056 Token BlockItem to RecordItem transformers #10168

Open
edwin-greene opened this issue Jan 17, 2025 · 5 comments · May be fixed by #10354
Open

HIP-1056 Token BlockItem to RecordItem transformers #10168

edwin-greene opened this issue Jan 17, 2025 · 5 comments · May be fixed by #10354
Assignees
Labels
enhancement Type: New feature importer Area: Importer

Comments

@edwin-greene
Copy link
Contributor

edwin-greene commented Jan 17, 2025

Problem

Add block item to record item transformers.

Solution

Add transformers for the following transaction types:
TokenCreate
TokenDelete
TokenUpdate
TokenAirdrop
TokenAssociate
TokenDissociate
TokenBurn
TokenCancel
TokenClaim
TokenReject
TokenFeeScheduleUpdate
TokenFreeze
TokenMint
TokenGrantKyc
TokenRevokeKyc
TokenUnFreeze
TokenPause
TokenUnpause
TokenUpdateNfts
TokenWipe

Alternatives

No response

@edwin-greene edwin-greene added enhancement Type: New feature importer Area: Importer labels Jan 17, 2025
@HarshSawarkar
Copy link
Contributor

Hi, I would like to work on this ticket.

@steven-sheehy
Copy link
Member

@HarshSawarkar #10191 might be easier to work on for you. Token services are probably our most complicated services and require a lot of domain knowledge. Or maybe you might want to just do a subset of the easier token transactions.

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Mirror Node Feb 2, 2025
@steven-sheehy steven-sheehy moved this from 📋 Backlog to 🏃‍♀ Sprint backlog in Mirror Node Feb 2, 2025
@HarshSawarkar
Copy link
Contributor

@HarshSawarkar #10191 might be easier to work on for you. Token services are probably our most complicated services and require a lot of domain knowledge. Or maybe you might want to just do a subset of the easier token transactions.

Thank you for your guidance, @steven-sheehy . I'll focus on working on #10191 and gradually explore implementing some token transformations. I'm eager to deepen my understanding of the domain and contribute more meaningfully to the community. Your insights and guidance would be truly appreciated.

@steven-sheehy
Copy link
Member

See https://github.com/hashgraph/hedera-services/blob/main/hedera-node/hedera-app/src/main/java/com/hedera/node/app/blocks/BlockItemsTranslator.java for similar mapping in consensus nodees. And see mirror node TransactionHandler implementations to see what receipt or record info is used.

@HarshSawarkar
Copy link
Contributor

See https://github.com/hashgraph/hedera-services/blob/main/hedera-node/hedera-app/src/main/java/com/hedera/node/app/blocks/BlockItemsTranslator.java for similar mapping in consensus nodees. And see mirror node TransactionHandler implementations to see what receipt or record info is used.

Sure, I will go through it

@edwin-greene edwin-greene self-assigned this Feb 3, 2025
@edwin-greene edwin-greene moved this from 🏃‍♀ Sprint backlog to 👷 In progress in Mirror Node Feb 3, 2025
@edwin-greene edwin-greene linked a pull request Feb 10, 2025 that will close this issue
2 tasks
@edwin-greene edwin-greene linked a pull request Feb 10, 2025 that will close this issue
2 tasks
@edwin-greene edwin-greene moved this from 👷 In progress to 👀 In review in Mirror Node Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature importer Area: Importer
Projects
Status: 👀 In review
Development

Successfully merging a pull request may close this issue.

3 participants