Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review all transactions and queries to verify data is not getting overwritten in the serialization and deserialization process #2101

Open
SimiHunjan opened this issue Nov 25, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@SimiHunjan
Copy link
Contributor

Problem

This bug raises some concerns in that there could be potentially be other places where data is overwritten in an unintended way when creating transactions/queries and following the serializing and deserializing process.

I know we couldn't fully test these transactions as Solo is still working on supporting these features so it could be that this case is specific to the node transactions. To be sure, we should look at doing the following:

  • Audit other transaction and query types across the SDK and verify there aren't any other cases the intended data input by the user is not being overwritten
  • Review our unit tests and add any missing test cases

Solution

See above

Alternatives

No response

@SimiHunjan SimiHunjan added the enhancement New feature or request label Nov 25, 2024
@SimiHunjan SimiHunjan added this to the v2.46.0 milestone Nov 25, 2024
@0xivanov 0xivanov self-assigned this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants