-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: remove inconsistent code analysis / align with hedera-services #2016
Conversation
sdk/src/test/java/com/hedera/hashgraph/sdk/ContractFunctionParametersTest.java
Show resolved
Hide resolved
84166df
to
98528e5
Compare
98528e5
to
fed3426
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have missed one @Var
in KeyTest.java
fed3426
to
69b1bd2
Compare
Thanks @0xivanov - fixed. Do you think this can be merged, or is there anything you would like to keep? |
63438db
to
170d10d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
170d10d
to
6e7e626
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some merge conflicts, should not be very hard to fix.
Signed-off-by: Jendrik Johannes <[email protected]>
6e7e626
to
b13d74b
Compare
I fixed the conflicts. Now you need to press the button one more time @0xivanov @rbarkerSL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
Addresses the following items in #1794
mergeJar("com.google.code.findbugs:jsr305")
This removes the setups for: sonar, error prone, spotbugs. Justification:
hedera-servcies
once we have the same Gradle setupAs we also do not use (and configure) these tools in hedera-services, my suggestion is to remove them for now. We can re-introduce one of these tools later again, but then with proper configuration that checks what you want to check and that works with errors (and not warnings).
Instead, the
javac
linting capabilities are now configured similar to how it is done in hedera-services. As preparation for sharing this configuration in the next step (hashgraph/hedera-services#14255).Related issue(s):
#1794 / hashgraph/hedera-services#14255
Notes for reviewer:
Checklist