Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Do not shutdown externally provided executor #2057

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

0xivanov
Copy link
Contributor

@0xivanov 0xivanov commented Nov 1, 2024

Description:

Do not shutdown externally provided executor.

Related issue(s):

Fixes #2035

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@0xivanov 0xivanov added the enhancement New feature or request label Nov 1, 2024
@0xivanov 0xivanov self-assigned this Nov 1, 2024
@0xivanov 0xivanov marked this pull request as ready for review November 6, 2024 09:38
@0xivanov 0xivanov requested a review from a team as a code owner November 6, 2024 09:38
@0xivanov 0xivanov requested a review from agadzhalov November 6, 2024 09:38
Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xivanov 0xivanov merged commit 0144164 into main Nov 6, 2024
11 checks passed
@0xivanov 0xivanov deleted the 2035-Client-should-not-shutdown-provided-executor branch November 6, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client should not shutdown provided executor
2 participants