Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Android): Executing transaction fails at runtime #2100

Merged
merged 1 commit into from
Nov 28, 2024
Merged

fix(Android): Executing transaction fails at runtime #2100

merged 1 commit into from
Nov 28, 2024

Conversation

0xivanov
Copy link
Contributor

@0xivanov 0xivanov commented Nov 25, 2024 •
edited
Loading

Description:

  • Replaces getModule() and Random , because it's not compatible with Android API 26

Related issue(s):

Fixes #2095

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@0xivanov 0xivanov added the bug Something isn't working label Nov 25, 2024
@0xivanov 0xivanov self-assigned this Nov 25, 2024
@0xivanov 0xivanov marked this pull request as ready for review November 26, 2024 13:11
@0xivanov 0xivanov requested a review from a team as a code owner November 26, 2024 13:11
agadzhalov
agadzhalov approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xivanov 0xivanov merged commit d88f7b4 into main Nov 28, 2024
11 checks passed
@0xivanov 0xivanov deleted the fix-android-issue branch November 28, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agadzhalov agadzhalov agadzhalov approved these changes

@SimiHunjan SimiHunjan Awaiting requested review from SimiHunjan SimiHunjan is a code owner automatically assigned from hashgraph/hedera-sdk-java-maintainers

Assignees

@0xivanov 0xivanov

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Send transaction has crashed in Android
2 participants
@0xivanov @agadzhalov