-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Token Airdrop Transaction #2492
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dda20d3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ty @ivaylonikolov7 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7a36f44
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
* feat: add airdrop claim and cancel transactions Signed-off-by: Ivaylo Nikolov <[email protected]> * chore: update protobufs Signed-off-by: Ivaylo Nikolov <[email protected]> * feat: update commit messages Signed-off-by: Ivaylo Nikolov <[email protected]> * test: add unit tests for cancel and claim Signed-off-by: Ivaylo Nikolov <[email protected]> * wip(test): add integration tests for cancel and claim transactions Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: claim used the wrong channel function Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: rename transaction name Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: remove claim references in airdropcancel integration test Signed-off-by: Ivaylo Nikolov <[email protected]> * test(fix): fix not working test for airdrop cancel and claim Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: airdropcancel transaction should work on sender not receiver Signed-off-by: Ivaylo Nikolov <[email protected]> * feat: add token airdrop example Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: rename transactions to have the same name as java Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: remove redundant imports and empty lines Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: rename transaction tests to have the same name as java sdk Signed-off-by: Ivaylo Nikolov <[email protected]> * docs: add licenses Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: remove dead code from token cancel Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: consistency in constructor Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: change airdrop_supply_per_person naming Signed-off-by: Ivaylo Nikolov <[email protected]> * test: fix setting sender id Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: specify what kind of tokens are airdropped Signed-off-by: Ivaylo Nikolov <[email protected]> --------- Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
27cada3
to
0e6079f
Compare
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
HIP 904 - Token Airdrop Transaction
This PR introduces AirdropTokenTransaction transaction. Adds AccountAmount and AirdropTokenTransfer helper classes.
Related issue(s):
Fixes #2465
Notes for reviewer:
Needs to have integration tests to be ready.
Checklist