Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileCreate/FileUpdate automatic chunking #2500

Closed
jbair06 opened this issue Sep 3, 2024 · 1 comment
Closed

FileCreate/FileUpdate automatic chunking #2500

jbair06 opened this issue Sep 3, 2024 · 1 comment
Labels
enhancement New feature or request p1
Milestone

Comments

@jbair06
Copy link
Member

jbair06 commented Sep 3, 2024

Problem

When creating or updating a file using the FileCreate or FileUpdate, if the contents are too large for a single transaction, a FileAppend is required to be created in addition to the FileCreate/Update.

FileAppend, on the other hand, can handle a large content because it does chunking of that content internally. It would be good to have FileCreate and FileUpdate to have this same functionality.

Solution

Refactor FileCreate, FileUpdate, and FileAppend to all share a base class. This base class will have the shared components, including the chunking logic currently located in FileAppend.

Alternatives

No response

@ivaylonikolov7
Copy link
Contributor

After some syncs with the transaction tool team they managed to fix this issue without the need of automatic chunking for FileCreate/FileUpdateTransaction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p1
Projects
None yet
Development

No branches or pull requests

4 participants